Control: tags -1 + patch Hi,
On Thu, Jan 29, 2026 at 01:57:41PM +0000, Santiago Vila wrote: > -------------------------------------------------------------------------------- > [...] > > CMake Error at > /usr/share/cmake-4.2/Modules/FindPackageHandleStandardArgs.cmake:290 > (message): > Could NOT find GTest (missing: GTEST_LIBRARY GTEST_INCLUDE_DIR > GTEST_MAIN_LIBRARY) > Call Stack (most recent call first): > /usr/share/cmake-4.2/Modules/FindPackageHandleStandardArgs.cmake:654 > (_FPHSA_FAILURE_MESSAGE) > /usr/share/cmake-4.2/Modules/FindGTest.cmake:421 > (find_package_handle_standard_args) > clients/CMakeLists.txt:138 (find_package) > > > -- Configuring incomplete, errors occurred! I looked into this and discovered that rocblas abuses nocheck. This seems to be a pattern in debian-ai and I have filed #1126934 to have lintian complain about this. When changing which packages are being built, nocheck is not applicable. That use case is served by a related build profile "noinsttest". The building of tests that are both installed into packages and run at build time can only be skipped when providing both nocheck and noinsttest. The rocblas package did not disable the build of benchmarks in nocheck builds and therefore failed locating gtest there. I am attaching a patch that fixes both the abuse of nocheck introducing the noinsttest build profile and also fixes the build with both profiles or either. I hope we can migrate rocblas soonish. The ppc64el removal has succeeded now. Helmut
diff -Nru rocblas-6.4.4/debian/changelog rocblas-6.4.4/debian/changelog --- rocblas-6.4.4/debian/changelog 2025-12-18 09:31:46.000000000 +0100 +++ rocblas-6.4.4/debian/changelog 2026-02-04 08:11:46.000000000 +0100 @@ -1,3 +1,10 @@ +rocblas (6.4.4-3.1) UNRELEASED; urgency=medium + + * Non-maintainer upload. + * Replace wrong use of nocheck with noinsttest. + * Do build tests, benchmarks and testdata when needed. (Closes: #1126608) + + -- Helmut Grohne <[email protected]> Wed, 04 Feb 2026 08:11:46 +0100 + rocblas (6.4.4-3) unstable; urgency=medium * Drop ppc64el as a supported architecture. diff -Nru rocblas-6.4.4/debian/control rocblas-6.4.4/debian/control --- rocblas-6.4.4/debian/control 2025-12-18 09:31:46.000000000 +0100 +++ rocblas-6.4.4/debian/control 2026-02-04 08:11:46.000000000 +0100 @@ -16,7 +16,7 @@ libamd-comgr-dev (>= 7.0~), libblas-dev, libdrm-dev, - libgtest-dev <!nocheck>, + libgtest-dev <!nocheck> <!noinsttest>, libhsa-runtime-dev (>= 6.4.3~), libmsgpack-cxx-dev, librocm-smi-dev, @@ -85,7 +85,7 @@ Section: libdevel Architecture: amd64 arm64 Depends: librocblas4 (= ${binary:Version}),${misc:Depends}, ${shlibs:Depends}, -Build-Profiles: <!nocheck> +Build-Profiles: <!noinsttest> Description: ROCm library for basic linear algebra - benchmarks rocBLAS is a library for performing basic linear algebra routines on AMD GPUs. It provides implementations of BLAS operations such as @@ -108,7 +108,7 @@ Architecture: amd64 arm64 Depends: librocblas4 (= ${binary:Version}),${misc:Depends}, ${shlibs:Depends}, librocblas4-tests-data -Build-Profiles: <!nocheck> +Build-Profiles: <!noinsttest> Description: ROCm library for basic linear algebra - tests rocBLAS is a library for performing basic linear algebra routines on AMD GPUs. It provides implementations of BLAS operations such as @@ -132,7 +132,7 @@ Section: libdevel Architecture: all Depends: ${misc:Depends}, -Build-Profiles: <!nocheck> +Build-Profiles: <!noinsttest> Description: ROCm library for basic linear algebra - test data rocBLAS is a library for performing basic linear algebra routines on AMD GPUs. It provides implementations of BLAS operations such as diff -Nru rocblas-6.4.4/debian/rules rocblas-6.4.4/debian/rules --- rocblas-6.4.4/debian/rules 2025-12-18 09:31:46.000000000 +0100 +++ rocblas-6.4.4/debian/rules 2026-02-04 08:11:46.000000000 +0100 @@ -1,4 +1,8 @@ #!/usr/bin/make -f + +FEATURE_CHECK := $(if $(filter nocheck,$(DEB_BUILD_OPTIONS) $(DEB_BUILD_PROFILES)),OFF,ON) +FEATURE_INSTTEST := $(if $(filter noinsttest,$(DEB_BUILD_PROFILES)),OFF,ON) + export CXX=hipcc export DEB_BUILD_MAINT_OPTIONS = hardening=+all optimize=-lto export DEB_CXXFLAGS_MAINT_PREPEND = -gz @@ -20,7 +24,7 @@ -DCMAKE_BUILD_TYPE=Release \ -DCMAKE_SKIP_INSTALL_RPATH=ON \ -DROCM_SYMLINK_LIBS=OFF \ - -DBUILD_CLIENTS_BENCHMARKS=ON \ + -DBUILD_CLIENTS_BENCHMARKS=$(FEATURE_INSTTEST) \ -DBUILD_FILE_REORG_BACKWARD_COMPATIBILITY=OFF \ -DGPU_TARGETS="$(shell rocm-target-arch --sep ';')" \ -DBUILD_WITH_HIPBLASLT=OFF \ @@ -33,17 +37,13 @@ -DTensile_LIBRARY_FORMAT=msgpack \ -DTensile_LAZY_LIBRARY_LOADING=ON \ -DTensile_SEPARATE_ARCHITECTURES=ON \ + -DBUILD_CLIENTS_TESTS=$(or $(filter ON,$(FEATURE_CHECK) $(FEATURE_INSTTEST)),OFF) \ $(DEBUG_FLAGS) \ -DBUILD_WITH_PIP=false \ -DOptions=--ignore-asm-cap-cache \ -DRUN_HEADER_TESTING=OFF \ -DBUILD_OFFLOAD_COMPRESS=OFF -ifeq (,$(filter nocheck,$(DEB_BUILD_PROFILES))) -CMAKE_FLAGS += \ - -DBUILD_CLIENTS_TESTS=ON -endif - %: dh $@ @@ -73,7 +73,7 @@ : override_dh_auto_build-indep: -ifeq (,$(filter nocheck,$(DEB_BUILD_PROFILES))) +ifeq ($(FEATURE_INSTTEST),ON) python3 clients/common/rocblas_gentest.py -I clients/include clients/gtest/rocblas_gtest.yaml -o rocblas_gtest.data endif
