On Fri, Jan 16, 2026 at 05:04:44AM +0100, Thorsten Glaser wrote:
> tags 1125611 + help
> outlook 1125611 patch to fix this welcome
> thanks
>...
> I’ve got absolutely no idea what these are about, and would
> require assistance with this. Bearing in mind that upstream
> likely also did not exactly know what they did and may have
> been cargo-culting these things.

Attached is are 2 patches backporting changes from musescore3.

I'm not 100% confident about the correctness/completeness, but they do 
fix the build for me and the resulting packages do not look obviously 
broken.

If you can test that the packages still work, then they might be 
good enough.

> Thanks in advance,
> //mirabilos

cu
Adrian
>From 8dd4bee158e4eea48c1e8e7dc9d6e67d7bb18f32 Mon Sep 17 00:00:00 2001
From: Joachim Schmitz <[email protected]>
Date: Fri, 15 Jun 2018 14:02:30 +0200
Subject: Remove old and deprecated cmake policies

1st was disabled already, 2nd and 3rd don't seem needed (anymore?),
I've seen no ill effects after this change.
The 4th needs a further change, which is also included in this commit.

At least CMake 3.11 reports them as deprecated and to be removed
from a future version.
---
 CMakeLists.txt | 36 +++++-------------------------------
 1 file changed, 5 insertions(+), 31 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 1fe3db4d97..583aaac28f 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -31,31 +31,6 @@ endif (CI)
  # Libraries linked via full path no longer produce linker search paths.
 cmake_policy(SET CMP0003 NEW)
 
-# Don't to link executables to qtmain.lib automatically when they link to the QtCore IMPORTED target
-if(POLICY CMP0020)
-      cmake_policy(SET CMP0020 OLD)
-endif(POLICY CMP0020)
-
-# ignore MACOSX_RPATH is not specified for awlplugin
-if(POLICY CMP0042)
-      cmake_policy(SET CMP0042 OLD)
-endif(POLICY CMP0042)
-
- # Issue no warning non-existent target argument to get_targer_property() and set the result variable to a -NOTFOUND value rather than issuing a FATAL_ERROR
-if(POLICY CMP0045)
-      cmake_policy(SET CMP0045 OLD)
-endif(POLICY CMP0045)
-
-# silently ignore non-existent dependencies (mops1, mops2)
-if(POLICY CMP0046)
-      cmake_policy(SET CMP0046 OLD)
-endif(POLICY CMP0046)
-
- # Honor the legacy behavior for variable references and escape sequences
-if(POLICY CMP0053)
-      cmake_policy(SET CMP0053 OLD)
-endif(POLICY CMP0053)
-
 # RPATH settings on macOS do not affect install_name
 if(POLICY CMP0068)
       cmake_policy(SET CMP0068 NEW)
@@ -384,23 +359,22 @@ IF(BUILD_JACK)
            IF("$ENV{PROCESSOR_ARCHITEW6432}" STREQUAL "")
               IF("$ENV{PROCESSOR_ARCHITECTURE}" STREQUAL "x86")
                  # "pure" 32-bit environment
-                 set (JACK_INCDIR "$ENV{PROGRAMFILES}/Jack/includes")
-                 set (JACK_LIB "$ENV{PROGRAMFILES}/Jack/lib/libjack.a")
+                 set (progenv "PROGRAMFILES")
               ELSE("$ENV{PROCESSOR_ARCHITECTURE}" STREQUAL "x86")
                  # "pure" 64-bit environment
-                 set (JACK_INCDIR "$ENV{PROGRAMFILES(x86)}/Jack/includes")
-                 set (JACK_LIB "$ENV{PROGRAMFILES(x86)}/Jack/lib/libjack.a")
+                 set (progenv "PROGRAMFILES(x86)")
               ENDIF("$ENV{PROCESSOR_ARCHITECTURE}" STREQUAL "x86")
            ELSE("$ENV{PROCESSOR_ARCHITEW6432}" STREQUAL "")
               IF("$ENV{PROCESSOR_ARCHITECTURE}" STREQUAL "x86")
                  # 32-bit program running with an underlying 64-bit environment
-                 set (JACK_INCDIR "$ENV{PROGRAMFILES(x86)}/Jack/includes")
-                 set (JACK_LIB "$ENV{PROGRAMFILES(x86)}/Jack/lib/libjack.a")
+                 set (progenv "PROGRAMFILES(x86)")
               ELSE("$ENV{PROCESSOR_ARCHITECTURE}" STREQUAL "x86")
                  # theoretically impossible case...
                  MESSAGE(SEND_ERROR "Error: Impossible program/environment bitness combination deduced: 64-bit program running in 32-bit environment. This is a programming error. PROCESSOR_ARCHITEW6432=$ENV{PROCESSOR_ARCHITEW6432}. PROCESSOR_ARCHITECTURE=$ENV{PROCESSOR_ARCHITECTURE}")
               ENDIF("$ENV{PROCESSOR_ARCHITECTURE}" STREQUAL "x86")
            ENDIF("$ENV{PROCESSOR_ARCHITEW6432}" STREQUAL "")
+           set (JACK_INCDIR "$ENV{${progenv}}/Jack/includes")
+           set (JACK_LIB "$ENV{${progenv}}/Jack/lib/libjack.a")
            MESSAGE("jack support enabled.")
      ELSE(MINGW)
            PKGCONFIG1 (jack ${JACK_MIN_VERSION} JACK_INCDIR JACK_LIBDIR JACK_LIB JACK_CPP)
-- 
2.47.3

Description: Fix FTBFS with CMake 4
From: Adrian Bunk <[email protected]>
Bug-Debian: https://bugs.debian.org/1125611
Origin: backport, https://github.com/musescore/MuseScore/commit/45e9d6247abb3bc7526030c13c438df60029c8c0

--- musescore2-2.3.2+dfsg4.orig/build/ECMQt4To5Porting.cmake
+++ musescore2-2.3.2+dfsg4/build/ECMQt4To5Porting.cmake
@@ -192,7 +192,6 @@ set(QT_LUPDATE_EXECUTABLE Qt5::lupdate)
 
 set(QT_INSTALL_PREFIX ${_qt5Core_install_prefix})
 
-get_target_property(QT_QMAKE_EXECUTABLE Qt5::qmake LOCATION)
 set(QT_RCC_EXECUTABLE Qt5::rcc LOCATION)
 if (TARGET Qt5::uic)
     get_target_property(QT_UIC_EXECUTABLE Qt5::uic LOCATION)

Reply via email to