Control: tags 1126239 + patch
Control: tags 1126239 + pending

Dear maintainer,

I've prepared an NMU for ros2-colcon-argcomplete (versioned as 0.3.3+ds-2.1)
and uploaded it to DELAYED/14. Please feel free to tell me if I should 
cancel it.

cu
Adrian
diffstat for ros2-colcon-argcomplete-0.3.3+ds ros2-colcon-argcomplete-0.3.3+ds

 changelog                                                             |    8 ++
 patches/0001-Drop-unnecessary-scope-qualifiers-to-please-flake8.patch |   39 ++++++++++
 patches/series                                                        |    1 
 3 files changed, 48 insertions(+)

diff -Nru ros2-colcon-argcomplete-0.3.3+ds/debian/changelog ros2-colcon-argcomplete-0.3.3+ds/debian/changelog
--- ros2-colcon-argcomplete-0.3.3+ds/debian/changelog	2022-03-13 20:02:43.000000000 +0200
+++ ros2-colcon-argcomplete-0.3.3+ds/debian/changelog	2026-02-21 21:03:58.000000000 +0200
@@ -1,3 +1,11 @@
+ros2-colcon-argcomplete (0.3.3+ds-2.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Backport upstream fix for FTBFS with flake8 7.3.0.
+    (Closes: #1126239)
+
+ -- Adrian Bunk <[email protected]>  Sat, 21 Feb 2026 21:03:58 +0200
+
 ros2-colcon-argcomplete (0.3.3+ds-2) unstable; urgency=medium
 
   * Fix installation location for shell completion files
diff -Nru ros2-colcon-argcomplete-0.3.3+ds/debian/patches/0001-Drop-unnecessary-scope-qualifiers-to-please-flake8.patch ros2-colcon-argcomplete-0.3.3+ds/debian/patches/0001-Drop-unnecessary-scope-qualifiers-to-please-flake8.patch
--- ros2-colcon-argcomplete-0.3.3+ds/debian/patches/0001-Drop-unnecessary-scope-qualifiers-to-please-flake8.patch	1970-01-01 02:00:00.000000000 +0200
+++ ros2-colcon-argcomplete-0.3.3+ds/debian/patches/0001-Drop-unnecessary-scope-qualifiers-to-please-flake8.patch	2026-02-21 20:44:31.000000000 +0200
@@ -0,0 +1,39 @@
+From 307b011341ecf82c2424c03e311c7c5768239465 Mon Sep 17 00:00:00 2001
+From: Scott K Logan <[email protected]>
+Date: Fri, 13 Feb 2026 14:25:58 -0600
+Subject: Drop unnecessary scope qualifiers to please flake8
+
+These variables are not assigned to, and so the scope qualifier is not
+necessary and may be misleading.
+---
+ colcon_argcomplete/argument_parser/argcomplete/__init__.py | 1 -
+ test/test_spell_check.py                                   | 1 -
+ 2 files changed, 2 deletions(-)
+
+diff --git a/colcon_argcomplete/argument_parser/argcomplete/__init__.py b/colcon_argcomplete/argument_parser/argcomplete/__init__.py
+index 4066114..12804a9 100644
+--- a/colcon_argcomplete/argument_parser/argcomplete/__init__.py
++++ b/colcon_argcomplete/argument_parser/argcomplete/__init__.py
+@@ -81,7 +81,6 @@ class ArgcompleteDecorator(ArgumentParserDecorator):
+ 
+     def parse_args(self, *args, **kwargs):
+         """Register argcomplete hook."""
+-        global _start_time
+         from argcomplete import autocomplete
+ 
+         # if requested log the duration the completion took into a file
+diff --git a/test/test_spell_check.py b/test/test_spell_check.py
+index f23aa6e..8d3b9da 100644
+--- a/test/test_spell_check.py
++++ b/test/test_spell_check.py
+@@ -17,7 +17,6 @@ spell_check_words_path = Path(__file__).parent / 'spell_check.words'
+ 
+ @pytest.fixture(scope='module')
+ def known_words():
+-    global spell_check_words_path
+     return spell_check_words_path.read_text().splitlines()
+ 
+ 
+-- 
+2.47.3
+
diff -Nru ros2-colcon-argcomplete-0.3.3+ds/debian/patches/series ros2-colcon-argcomplete-0.3.3+ds/debian/patches/series
--- ros2-colcon-argcomplete-0.3.3+ds/debian/patches/series	2022-03-13 20:02:43.000000000 +0200
+++ ros2-colcon-argcomplete-0.3.3+ds/debian/patches/series	2026-02-21 21:03:37.000000000 +0200
@@ -2,3 +2,4 @@
 0002-pass-with-flake8-3.8-34.patch
 0003-Suppress-deprecation-warnings-in-other-packages.patch
 0004-Do-not-install-completion-scripts-with-setuptools.patch
+0001-Drop-unnecessary-scope-qualifiers-to-please-flake8.patch

Reply via email to