Your message dated Tue, 01 Sep 2026 09:04:48 +0000
with message-id <[email protected]>
and subject line Bug#1146232: fixed in testdisk 7.2-2
has caused the Debian Bug report #1146232,
regarding testdisk: debian/copyright misses several upstream authors, file
mappings, and GPL-2-only license terms
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
1146232: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1146232
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: src:testdisk
Version: 7.2-0.2
Severity: serious
Justification: Policy 12.5 (DFSG copyright & license documentation requirements)
Dear Jean-Michel,
While reviewing testdisk 7.2-1 in the NEW queue, I conducted a DFSG and
copyright audit comparing the upstream source tree against debian/copyright.
The audit revealed several pre-existing discrepancies in debian/copyright
(also present in 7.2-0.2 currently in unstable). Under Debian Policy §12.5,
all copyright notices and distinct license terms must be accurately recorded.
Below is a structured summary of the findings, followed by a proposed
patch updating debian/copyright.
======================================================================
1. License Scope Mismatches (GPL-2 vs GPL-2+)
======================================================================
Several filesystem header files are explicitly licensed under GNU GPL v2
*only* (lacking the "or (at your option) any later version" clause), but
are currently covered under the catch-all GPL-2+ stanza:
- src/refs.h (lines 4-6)
- src/ufs.h (lines 4-6)
- src/xfs.h (lines 4-6)
- src/xfs_struct.h (lines 4-6)
Header quote:
"under the terms of version 2 of the GNU General Public License as
published by the Free Software Foundation."
======================================================================
2. Missing Upstream Authors & Attributions
======================================================================
The following source files contain explicit third-party copyright notices
that are currently omitted from debian/copyright:
| File(s) | Copyright Holder / Author |
Year(s) |
|-----------------------|-----------------------------------------------|-------------|
| src/file_bpg.c:6 | Dmitry Brant <[email protected]> |
2016 |
| src/file_mkv.c:6 | Nick Schrader <[email protected]> | 2011
|
| src/file_xm.c:6 | Christophe GISQUET <[email protected]> |
2007 |
| src/file_zip.c:6 | Christophe GISQUET <[email protected]> |
2007 |
| src/dfxml.c:5 | Simson Garfinkel | 2011
|
| src/dfxml.h:5 | Simson Garfinkel | 2011
|
| src/pe.h:3 | Tomasz Kojm <[email protected]> |
2004-2005 |
| src/rfs.h:6 | Hans Reiser (ReiserFS v0.91) |
1996-1998 |
| src/hfsp_struct.h:7-9 | Klaus Halfmann <[email protected]> | 2000
|
| | Robert Leslie <[email protected]> |
1996-1998 |
| | Brad Boyer <[email protected]> | 2000
|
| src/suspend.c:8 | Michael Cohen <[email protected]>| 2008
|
| src/md.h:24 | Ingo Molnar, Gadi Oxman |
1996-1998 |
| src/jfs_superblock.h:4| International Business Machines Corp. |
2000-2002 |
| src/lvm.h:9 | Michail Brzitwa <[email protected]> (gpart) |
1999-2001 |
| src/memmem.h:6 | Free Software Foundation, Inc. (glibc) |
1991-2004 |
| src/ntfs_dir.c:7 | Lode Leroy (Linux-NTFS project) | 2003
|
| src/ntfs_utl.c:7 | Lode Leroy (Linux-NTFS project) | 2003
|
| src/ntfs_io.c:5 | Anton Altaparmakov |
2000-2003 |
======================================================================
3. Incomplete File Lists in Existing Stanzas
======================================================================
- James Holodnak stanza: covers `src/file_fds.c`, but should also include
`src/file_nes.c` (line 5: Copyright (C) 2013 James Holodnak).
- Peter Turczak stanza: covers `src/file_fh5.c`, but should also include
`src/file_fh10.c` and `src/file_indd.c` (and the alternate email address
`<[email protected]>`).
- NTFS stanza: covers `src/ntfs_udl.c` and `src/ntfs_dir.c`, but should
also include `src/ntfs_utl.c` and `src/ntfs_io.c`.
======================================================================
4. Copyright Year Coverage
======================================================================
The catch-all stanza `Files: *` lists `1998-2018 Christophe Grenier`, whereas
upstream file headers and the `INFO` file show copyright notices through 2024
(`1998-2024 Christophe GRENIER <[email protected]>`).
======================================================================
Proposed Patch (debian/copyright)
======================================================================
Below is the proposed update to debian/copyright to resolve all of the above:
--- a/debian/copyright
+++ b/debian/copyright
@@ -3,48 +3,130 @@
Source: https://www.cgsecurity.org/
Files: *
-Copyright: 1998-2018 Christophe Grenier <[email protected]>
+Copyright: 1998-2024 Christophe Grenier <[email protected]>
License: GPL-2+
+Files: src/refs.h
+ src/ufs.h
+ src/xfs.h
+ src/xfs_struct.h
+Copyright: 1998-2024 Christophe Grenier <[email protected]>
+License: GPL-2
+
Files: src/ntfs_udl.c
src/ntfs_dir.c
-Copyright: 2002-2005 Richard Russon
+ src/ntfs_utl.c
+Copyright: 2004-2008 Christophe Grenier <[email protected]>
+ 2002-2005 Richard Russon
2004-2005 Holger Ohmacht
- 2005 Anton Altaparmakov
+ 2003-2005 Anton Altaparmakov
+ 2003 Lode Leroy
+License: GPL-2+
+
+Files: src/ntfs_io.c
+Copyright: 2004-2006 Christophe Grenier <[email protected]>
+ 2000-2003 Anton Altaparmakov
License: GPL-2+
Files: src/file_fh5.c
+ src/file_fh10.c
+ src/file_indd.c
Copyright: 2007 Christophe GRENIER <[email protected]>
2007 Peter Turczak <[email protected]>
+ 2007 Peter Turczak <[email protected]>
License: GPL-2+
Files: src/file_fds.c
+ src/file_nes.c
Copyright: 2013 James Holodnak <[email protected]>
License: GPL-2+
+Files: src/file_bpg.c
+Copyright: 1998-2007 Christophe GRENIER <[email protected]>
+ 2016 Dmitry Brant <[email protected]>
+License: GPL-2+
+
+Files: src/file_mkv.c
+Copyright: 1998-2011 Christophe GRENIER <[email protected]>
+ 2011 Nick Schrader <[email protected]>
+License: GPL-2+
+
Files: src/file_shp.c
Copyright: 2023 Grzegorz Szymaszek <[email protected]>
License: GPL-2+
+Files: src/file_xm.c
+ src/file_zip.c
+Copyright: 1998-2009 Christophe GRENIER <[email protected]>
+ 2007 Christophe GISQUET <[email protected]>
+License: GPL-2+
+
Files: src/crc.c
Copyright: 2007 Christophe GRENIER <[email protected]>
1986 Gary S. Brown for the crc32 table
License: GPL-2+
+Files: src/dfxml.c
+ src/dfxml.h
+Copyright: 2011 Simson Garfinkel
+ 2011 Christophe Grenier <[email protected]>
+License: GPL-2+
+
+Files: src/hfsp_struct.h
+Copyright: 2005-2006 Christophe GRENIER <[email protected]>
+ 2000 Klaus Halfmann <[email protected]>
+ 1996-1998 Robert Leslie <[email protected]>
+ 2000 Brad Boyer <[email protected]>
+License: GPL-2+
+
+Files: src/jfs_superblock.h
+Copyright: 2004 Christophe GRENIER <[email protected]>
+ 2000-2002 International Business Machines Corp.
+License: GPL-2+
+
+Files: src/lvm.h
+Copyright: 2003-2008 Christophe GRENIER <[email protected]>
+ 1999-2001 Michail Brzitwa <[email protected]>
+License: GPL-2+
+
+Files: src/md.h
+Copyright: 1998-2004 Christophe GRENIER <[email protected]>
+ 1996-1998 Ingo Molnar, Gadi Oxman
+License: GPL-2+
+
+Files: src/memmem.h
+Copyright: 2005-2007 Christophe GRENIER <[email protected]>
+ 1991, 1992, 1993, 1994, 1996, 1997, 1998, 2000, 2004 Free Software
Foundation, Inc.
+License: GPL-2+
+
+Files: src/pe.h
+Copyright: 2007 Christophe Grenier <[email protected]>
+ 2004-2005 Tomasz Kojm <[email protected]>
+License: GPL-2+
+
+Files: src/rfs.h
+Copyright: 2005-2006 Christophe GRENIER <[email protected]>
+ 1996-1998 Hans Reiser
+License: GPL-2+
+
+Files: src/suspend.c
+Copyright: 2009 Christophe GRENIER <[email protected]>
+ 2008 Michael Cohen <[email protected]>
+License: GPL-2+
+
Files: debian/*
Copyright: 2004-2019 Jean-Michel Kelbert <[email protected]>
License: GPL-2+
+License: GPL-2
+ This program is free software; you can redistribute it and/or modify it
+ under the terms of version 2 of the GNU General Public License as
+ published by the Free Software Foundation.
+ .
+ This program is distributed in the hope that it will be useful, but
+ WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+ .
+ On Debian GNU/Linux systems, the complete text of the GNU General
+ Public License version 2 can be found in `/usr/share/common-licenses/GPL-2'.
+
License: GPL-2+
This software is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
regards,
-rt
--- End Message ---
--- Begin Message ---
Source: testdisk
Source-Version: 7.2-2
Done: Juan Manuel Méndez Rey <[email protected]>
We believe that the bug you reported is fixed in the latest version of
testdisk, which is due to be installed in the Debian FTP archive.
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Juan Manuel Méndez Rey <[email protected]> (supplier of updated testdisk
package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
Format: 1.8
Date: Mon, 31 Aug 2026 23:43:21 +0200
Source: testdisk
Architecture: source
Version: 7.2-2
Distribution: unstable
Urgency: medium
Maintainer: Debian Security Tools <[email protected]>
Changed-By: Juan Manuel Méndez Rey <[email protected]>
Closes: 1146232
Changes:
testdisk (7.2-2) unstable; urgency=medium
.
* Fix debian/copyright: correct GPL-2-only headers, add missing
upstream authors, extend consolidated Files stanzas, and update
catch-all copyright years (Closes: #1146232).
Checksums-Sha1:
d5dccb8394bef2ab83d146a7108e92ed1f66b1d5 2170 testdisk_7.2-2.dsc
9e9ac2e67d657e198852db56a353178b30e8421f 6644 testdisk_7.2-2.debian.tar.xz
3d58b55ca96539c763d95eaf1d07c0bc857f7c19 12353 testdisk_7.2-2_amd64.buildinfo
Checksums-Sha256:
5bf7a70c00043dc143047844ea2159ec9d99d0c1012916f8acd225c495846200 2170
testdisk_7.2-2.dsc
d61f6149c2429ddd1c300c0174d19bb50fff311222ffe60ab7eb1212e012b60b 6644
testdisk_7.2-2.debian.tar.xz
ff6e31fba8355411ab52f97c90fde63f4cf0ec34a54b0d39b1cfebe7467566b4 12353
testdisk_7.2-2_amd64.buildinfo
Files:
c1d93039027acbbfe5dd19cd874b3e00 2170 admin optional testdisk_7.2-2.dsc
92de88968f32e3b8a1856b666106e18f 6644 admin optional
testdisk_7.2-2.debian.tar.xz
4d51f4c483352ce1a8389c32492c3e16 12353 admin optional
testdisk_7.2-2_amd64.buildinfo
-----BEGIN PGP SIGNATURE-----
iQJFBAEBCgAvFiEE8fAHMgoDVUHwpmPKV4oElNHGRtEFAmqWkkcRHHRpbGxlQGRl
Ymlhbi5vcmcACgkQV4oElNHGRtHjgg/8DesZYVeUPsuPJx+wxTKfI0GTForV5/Ma
POoa+JdW1HQ5X+3fosJcZyzK8Hggm2f+ZgLdfO2m3q9B6+EWCYOM8uPoiwOW55gy
z33mibjaC47Yo9Pvyih5LfxTA8bXIDrfEznNBotzmVnscpMYo3+HZ3z7kVZXuCiH
cEcL7ARDFeGl3WHsDB5OyBG8MVAAnZbStAyNJu9MXNiBt1fllo9SQJjulMZK1KZH
hzzGHk9JYyO8ibE9P3idsGMCdwNsuzgItUnImW5/zEoKjA3tcI7Drz3A4QxuWZUr
2O3L9BWRGhVTk/n08lV7nS+5ntgD3Jn7v5WHd6lkTq524NQJKHPnZaQF1kGlXj0i
7i0vD9WeJJgdTTiycVfVU1lP0HuGW1UishQKZaTUmVI5ZbtmsD2gY/K9BZNsHFdl
VMVdQ6CHL4hrmSs2Cmk7og3doDZWBFGZ7afXVo4qZOHuPzb22CIS1Dzl10ZHe0i3
2DMR+OPJnSO/Pfg29ru2/9zd6bq/45ggAUs2Wn2/npuSNr9NyKwQ3mfK4Z/0IXlL
rIqbiifzhlfvloDi54vfuC3x7A02Qy9ezNZD5EEkNQPE6ndY7fTqhiOFL/PJ54zq
4sgP8pyLBh9TBCmtqxKVv5vlyYWMstcVY9LLmGrqbeKSwhwipQJRIkZDivXH1/9J
2h7PBBdvzys=
=t9u7
-----END PGP SIGNATURE-----
pgp5x_suJzrgV.pgp
Description: PGP signature
--- End Message ---
