Package: src:numix-gtk-theme
Version: 2.6.7+git20210608.ad4b345-1
Severity: serious
Tags: ftbfs forky sid patch
Dear maintainer:
During a rebuild of all packages in unstable, this package failed to build.
The failure happens randomly, approximately 50% of the time on machines with 2
CPUs.
Full build log is available here:
https://people.debian.org/~sanvila/build-logs/202610/
The problem is a race condition in the Makefile. Target "all" depends
on both "clean" and "gresource", like this:
all: clean gresource
but this does not specify any order, so they can run in parallel, which makes
"clean things" to be run at the same time as "build and/or install things".
There is not, in fact, any need to run the clean target here. Debian packages
already run the clean target before starting the build.
The attached patch might fix this, it also uses mkdir -p so that creating
directories is idempotent.
Thanks.
--------------------------------------------------------------------------------
[...]
dh_auto_install --destdir=debian/numix-gtk-theme/
make -j2 install
DESTDIR=/<<BUILDDIR>>/numix-gtk-theme-2.6.7\+git20210608.ad4b345/debian/numix-gtk-theme
AM_UPDATE_INFO_DIR=no INSTALL="install --strip-program=true"
make[1]: Entering directory '/<<PKGBUILDDIR>>'
rm -rf src/gtk-3.0/dist
mkdir src/gtk-3.0/dist
mkdir: cannot create directory ‘src/gtk-3.0/dist’: File exists
make[1]: *** [Makefile:17: css] Error 1
make[1]: *** Waiting for unfinished jobs....
rm -f src/gtk-3.0/gtk.gresource
rm -rf src/gtk-3.20/dist
rm -f src/gtk-3.20/gtk.gresource
rm -rf /dist
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_install: error: make -j2 install
DESTDIR=/<<BUILDDIR>>/numix-gtk-theme-2.6.7\+git20210608.ad4b345/debian/numix-gtk-theme
AM_UPDATE_INFO_DIR=no INSTALL="install --strip-program=true" returned exit code 2
make: *** [debian/rules:4: binary] Error 25
dpkg-buildpackage: error: debian/rules binary subprocess failed with exit
status 2
----------------------------------------------------------------------------------- a/Makefile
+++ b/Makefile
@@ -11,13 +11,13 @@ INSTALL_DIR=$(DESTDIR)/usr/share/themes/Numix
ROOT_DIR=${PWD}
UTILS=scripts/utils.sh
-all: clean gresource
+all: gresource
css:
- mkdir $(DIST_DIR)
+ mkdir -p $(DIST_DIR)
$(SASS) $(SASSFLAGS) $(SCSS_DIR)/gtk.scss $(DIST_DIR)/gtk.css
$(SASS) $(SASSFLAGS) $(SCSS_DIR)/gtk-dark.scss $(DIST_DIR)/gtk-dark.css
- mkdir $(DIST_DIR320)
+ mkdir -p $(DIST_DIR320)
$(SASS) $(SASSFLAGS) $(SCSS_DIR320)/gtk.scss $(DIST_DIR320)/gtk.css
$(SASS) $(SASSFLAGS) $(SCSS_DIR320)/gtk-dark.scss
$(DIST_DIR320)/gtk-dark.css
