tags 395321 + patch
thanks

Hello,

I fix  this bug  by using module_param  instead of MODULE_PARM  which is
deprecated (in favor of module_param) and not type-safe.  It builds fine
but could  you please try this patch  and tell me if  the module behaves
correctly? If so, I will prepare a NMU.

Regards,
Arnaud Fontaine

--- vaiostat.c.old	2006-12-06 23:06:23.000000000 +0100
+++ vaiostat.c	2006-12-06 23:13:12.000000000 +0100
@@ -42,6 +42,7 @@
 #include <linux/kernel.h>
 #include <linux/proc_fs.h>
 #include <linux/delay.h>
+#include <linux/moduleparam.h>
 #include <asm/uaccess.h>
 #include <asm/io.h>
 
@@ -326,10 +327,10 @@
 MODULE_DESCRIPTION("Support selected Sony Vaio features.");
 MODULE_LICENSE("GPL");
 
-MODULE_PARM(verbose,"i");
+module_param(verbose, int, 0);
 MODULE_PARM_DESC(verbose, "be verbose, default is 0 (no)");
 
-MODULE_PARM(umask,"i");
+module_param(umask, int, 0);
 MODULE_PARM_DESC(umask, "umask for /proc/vaio entries, default 0777");
 
 #ifdef EXPORT_NO_SYMBOLS

Attachment: pgpC0UrOaPGUi.pgp
Description: PGP signature

Reply via email to