tags 408730 patch
thanks
On Sun, Jan 28, 2007 at 12:17:05AM +0100, Sam Hocevar wrote:
> gtoaster crashes immediately on startup. I have the time to see the
> window open briefly, but that's all.
> Here is a backtrace:
> Program received signal SIGSEGV, Segmentation fault.
> #0 0xb792475b in strlen () from /lib/tls/libc.so.6
> #1 0xb78dc755 in gettext () from /lib/tls/libc.so.6
> #2 0xb78dbe8d in dcgettext () from /lib/tls/libc.so.6
> #3 0x0806d845 in helpings_translatestringlist ()
> #4 0x0806fbf7 in cddrives_init ()
> #5 0x08057c1f in main ()
helpings_translatestringlist() expects a NULL-terminated list of strings.
The cddrives_dltitles[] list in cddrives.c is not NULL-terminated.
All other callers of helpings_translatestringlist are ok, so the attached
patch should take care of this bug.
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
[EMAIL PROTECTED] http://www.debian.org/
diff -u gtoaster-0.2002083100+1.0Beta6/debian/changelog gtoaster-0.2002083100+1.0Beta6/debian/changelog
--- gtoaster-0.2002083100+1.0Beta6/debian/changelog
+++ gtoaster-0.2002083100+1.0Beta6/debian/changelog
@@ -1,3 +1,12 @@
+gtoaster (0.2002083100+1.0Beta6-2.3) unstable; urgency=high
+
+ * Non-maintainer upload.
+ * High-urgency upload for RC bugfix.
+ * NULL-terminate the cddrives_dltitles list being passed to
+ helpings_translatestringlist(). Closes: #408730.
+
+ -- Steve Langasek <[EMAIL PROTECTED]> Sat, 3 Feb 2007 21:42:46 -0800
+
gtoaster (0.2002083100+1.0Beta6-2.2) unstable; urgency=high
* Non-maintainer upload.
only in patch2:
unchanged:
--- gtoaster-0.2002083100+1.0Beta6.orig/cddrives.c
+++ gtoaster-0.2002083100+1.0Beta6/cddrives.c
@@ -161,7 +161,8 @@
N_("Manufacturer Name"),
N_("Device Name"),
N_("Scsi ID"),
- N_("Mountpoint")
+ N_("Mountpoint"),
+ NULL
};
/* this loads the drive list out of a given position of the config file */
