tags 402753 patch
clone 402753 -1
severity -1 normal
retitle -1 lilypond-doc: building succeeds even if rsync commands fail
thanks
"Yitzchak Gale" <[EMAIL PROTECTED]> wrote:
> Frank Küster wrote:
>> Well, there are still the info files. Whether it is grave or important
>> to not include the html docs, this I leave to the maintainer.
>
> Never mind, let's fix it!
>
>> However, the bug can be fixed by adding rsync to Build-Depends-Indep.
>> At least this helped when I tried in a pbuilder chroot, using
>> "debian/rules binary-indep". I'm currently trying with
>> pbuilder/dpkg-buildpackage and a complete build.
>
> Great! Hope it works.
It does.
-Build-Depends-Indep: netpbm (>= 2:9.10-1), imagemagick, emacs-intl-fonts,
xfonts-intl-arabic, xfonts-intl-asian, xfonts-intl-chinese,
xfonts-intl-chinese-big, xfonts-intl-european, xfonts-intl-japanese,
xfonts-intl-japanese-big, xfonts-intl-phonetic, ttf-kochi-gothic,
ttf-kochi-mincho, ttf-bitstream-vera, ttf-freefont, gsfonts | gsfonts-x11
+Build-Depends-Indep: netpbm (>= 2:9.10-1), imagemagick, emacs-intl-fonts,
xfonts-intl-arabic, xfonts-intl-asian, xfonts-intl-chinese,
xfonts-intl-chinese-big, xfonts-intl-european, xfonts-intl-japanese,
xfonts-intl-japanese-big, xfonts-intl-phonetic, ttf-kochi-gothic,
ttf-kochi-mincho, ttf-bitstream-vera, ttf-freefont, gsfonts | gsfonts-x11, rsync
>> However, I think even if this helps to re-include the html
>> documentation, there is still a bug left, and that is that the package
>> builds fine even when this command fails.
>
> At least that's not RC.
Yes, cloning as a normal bug.
>> If that's true, then
>>
>> rsync -a --link-dest $$a/ $$a/ $$a/.. && rm -rf $$a ; \
>>
>> might do (or not, since the for loop might still be successful if only
>> the first rsync call fails for some reason.
It doesn't help, this test case always proceeds without an error:
all:
for name in a b c; \
do test "$$name" = "c" && true; \
done
echo "fine."
> So then how about something like
>
> rsyncres=0 \
> for a in `find . -name out-www`; do \
> if rsync -a --link-dest $$a/ $$a/ $$a/.. ; \
> then rm -rf $$a ; \
> else rsyncres=1; break; \
> fi; \
> done; \
> [ $$rsyncres -eq 0 ]
>
> A bit messy, but should do it.
It needs a bit more semicolons to run fine. This one made my tests:
all-check:
rsyncres=0 ; \
for name in a b c; do \
echo $$name; \
if [ "$$name" = "c" ]; then \
true;\
else \
rsyncres=1; \
fi \
done; \
[ $$rsyncres -eq 0 ] || (echo "problem with rsync"; exit 1)
Regards, Frank
--
Dr. Frank Küster
Single Molecule Spectroscopy, Protein Folding @ Inst. f. Biochemie, Univ. Zürich
Debian Developer (teTeX/TeXLive)
