tags + patch
thanks
> Package: dh-kpatches
> Version: 0.100.1
> Severity: grave
> Tags: experimental
> Justification: renders package unusable
>
> I built a kernel-patch package for the hard disk queue freezing patch
> that is used with the IBM ThinkPad HDAPS support code. It was built with
> dh-kpatches 0.100.1, and I was told by a user that this package does not
> work. The following errors are made in the apply perl script:
>
> a) line 63
> if (defined $DEBPATCHFILES[$IDX] ...
> is the wrong test since an empty string is defined in perl.
> It should be
> if( not ($DEBPATCHFILES[$IDX] eq "") ....
I think it really should be checking for definedness. Just in case,
I've added a check for empty string as well in the attached patch.
> b) line 153
> printf 'Disk queue freezing support (queuefreeze)"
> has inconsistent quotation marks
I've fixed this in the attached patch...
In any case, neither of these problems exist in the version in unstable
-- can you use it instead of the one in experimental for now?
John
diff -Nur dh-kpatches-0.100.1.orig/dh-kpatches.nw dh-kpatches-0.100.1/dh-kpatches.nw
--- dh-kpatches-0.100.1.orig/dh-kpatches.nw 2003-12-16 01:54:17.000000000 -0700
+++ dh-kpatches-0.100.1/dh-kpatches.nw 2007-02-15 01:01:38.000000000 -0700
@@ -241,7 +241,7 @@
our $STRIPLEVEL=$STRIPLEVELS[$IDX];
our $PATCHFILE;
-if (defined $DEBPATCHFILES[$IDX] and
+if (defined $DEBPATCHFILES[$IDX] and $DEBPATCHFILES[$IDX] ne "" and
(-r 'version.Debian' or -r 'README.Debian' )) {
$PATCHFILE=$DEBPATCHFILES[$IDX];
} else {
@@ -350,7 +350,7 @@
mkdir -p \${docdir}
(
- printf '#PATCHNAME# (#PATCHID#)"
+ printf '#PATCHNAME# (#PATCHID#)'
EOF
;
print REGISTER " printf 'for kernel $ENV{KPATCH_#CLEANPATCHID#},'\n"
