On 06/27/2017 09:10 PM, jhcha54008 wrote: > I was not aware of all the intricacies of the hurd-i386 repositories. > Thank you for the clarification and the correction.
You were right, however. After checking back with Aurelien I have learnt that, hurd-i386 actually uses debian-ports.org for "unreleased" packages so this is all good :). > >> >>> - BINCLUDE=`[ -n "$(BASE_INCLUDE)" ] && cat >>> $(BASE_INCLUDE) | tr "\n" "," | sed 's!,$$!!g'`; \ >>> + BINCLUDE=`[ -n "$(BASE_INCLUDE)" ] && cat >>> $(BASE_INCLUDE) | sort -u | tr "\n" "," | sed 's!,$$!!g'`; \ >> >> I'm not sure I understand why you added the additional "sort -u" here. Is >> the order >> of packages important? Did you get an error when building a CD without it? >> > > Indeed, that should not be necessary. Nowadays, debootstrap removes > duplicates. The reason was to avoid including debian-ports-archive-keyring > twice - in case BASE_INCLUDE is set by the user and includes > debian-ports-archive-keyring. Ok. Thanks for the explanation. > >>> --- /dev/null >>> +++ b/data/base_include_port_architectures >>> @@ -0,0 +1 @@ >>> +debian-ports-archive-keyring >> >> I think that should be "base_include_ports_architectures" with an "s", same >> above. >> > > I was unsure about the total number of 's'. Thank you for the correction. No worries. Your patch has been now applied by Steve as is so I think we can leave it for now. Thanks again for fixing this! Adrian -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - [email protected] `. `' Freie Universitaet Berlin - [email protected] `- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
