On Tue, May 14, 2019 at 10:27:45AM +0200, Johannes Schauer wrote: > Quoting Adrian Bunk (2019-05-14 10:11:46) > > > > How well are you testing such conversions? > > Based on work I've seen from you I'd guess your NMU would be better than > > average. Unfortunately this is not generally true. > > > > Based on what enters the archive, "debdiff between old and new package" > > already seems to be something that many people are not doing - then > > cleaning up after mass-NMUs would be much work. > > > > I have even seen maintainers blindly replacing a complex old > > debian/rules with the dh 3-liner, and all the bugfixes and > > workarounds in the old one were bugs again. > > > > To show the quantitative side of my argument: > > > > The default change to parallel building in dh compat 10 alone has caused > > a three digit number of RC bugs, popping up at a pace of 1-2 RC bugs > > per week for several years. > > > > The problem is that anything that works for only 99% of all packages > > results in such a high number of new bugs. > > > > Parallel build bugs slipping through an upload can happen, > > but maintainers not going through the upgrading checklist > > and running debdiff between old and new packages as well > > as testing them when doing dh compat bumps is harder to > > excuse - and in practice this does happen. > > > > There is no perfect solution here > > What makes reproducible-builds not the perfect fit for this? > > Whenever I converted a package to dh or bumped debhelper compat level, I > always > checked whether the produced binaries were bit-by-bit identical to the ones > before.
Don't assume everyone follows the same high standards as you do. > Are there many errors that I would be missing by relying on reproducibility > results? The parallel build issues I mentioned might be missed, but this is more exceptional. dh compat 12 defaulting to dh_dwz might make the -dbgsym packages different, and other intentional differences might exist. > Thanks! > > cheers, josch cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed