On Tue, Jun 20, 2023 at 02:17:38PM +0200, Ricardo Ribalda Delgado wrote: > Hi Andrea > > On Tue, Jun 20, 2023 at 10:02 AM Andrea Righi > <andrea.ri...@canonical.com> wrote: > > > > On Tue, Jun 20, 2023 at 09:19:58AM +0200, Andrea Righi wrote: > > > On Tue, Jun 20, 2023 at 08:47:54AM +0200, Ricardo Ribalda Delgado wrote: > > > > On Tue, Jun 20, 2023 at 7:46 AM Andrea Righi > > > > <andrea.ri...@canonical.com> wrote: > > > > > > > > > > On Mon, Jun 19, 2023 at 09:54:41PM +0200, Ricardo Ribalda Delgado > > > > > wrote: > > > > > > Hi > > > > > > > > > > > > I have updated my repo to uprev v1.10 and support argcomple3. > > > > > > > > > > > > https://salsa.debian.org/ribalda/virtme-ng/-/tree/debian > > > > > > > > > > > > Hector, Andrea, can you take a look at it? > > > > > > > > > > > > Hector the fun bits are at > > > > > > https://salsa.debian.org/ribalda/virtme-ng/-/merge_requests/1/diffs?commit_id=943dd90136e5e30fc39d0061347fea3bcbe44c4c > > > > > > > > > > Reviewed and added some comments, thanks! > > > > > > > > > > > > > > > > > Andrea: the build seems to be having issues with 32 bits: > > > > > > https://salsa.debian.org/ribalda/virtme-ng/-/jobs/4338837 > > > > > > > > > > Ah yes, I hit that yesterday as well: > > > > > https://launchpadlibrarian.net/673040751/buildlog_ubuntu-mantic-armhf.virtme-ng_1.12-1ubuntu1_BUILDING.txt.gz > > > > > > > > Can you check if > > > > https://salsa.debian.org/ribalda/virtme-ng/-/blob/debian/debian/patches/32bit.patch > > > > does the trick for you? > > > > > > usize seems to do the trick for me, I think it's more portable than > > > c_ulong (that comes from std::os::raw:c_ulong). > > I thought that std::os::raw:c_ulong was more or less ok, as I said... > me no rust :P
I think they are both ok, I prefer usize just because it is more idiomatic Rust (usize is actually a distinct type) and c_ulong is provided to maintain compatibility with libc. > > > > > > > > I'll push a fix soon, I just want to make sure it builds everywhere > > > (testing right now). :) > > > > I confirm that this one seems to fix the build error: > > https://github.com/arighi/virtme-ng/commit/438158e15a8af04fadfbb3943a227271db4b6e29 > > > > I'd like to cut a new version (v1.11) at this point, if/when you have a > > new PR ready I can also include your changes (no rush). > > Cool, let me know when you want to land it, so I update my package. Ok, will do. > > I have added support for cross-compilation of the package: > https://salsa.debian.org/ribalda/virtme-ng/-/commit/0e6ffec3897504ef1b7af7171f3b9cf68decfc76 > > Also, to ease the development at some point we should converge on the > content of the debian folder. Is the package already in ubuntu? Absolutely, I would like to apply all your changes so that the content of debian/ upstream will be the same as yours. The package for Ubuntu is only available in a ppa at the moment. My plan is to land a proper package in Debian and then ask a resync of the same package in Ubuntu. Thanks, -andrea
