Hi,

sorry for making the work on my side our emails arrive with a 2 minute
delay...;-(

On Wed, Apr 13, 2005 at 10:04:33PM +0200, Jens Seidel wrote:


[...]
> all: html pdf # dvi ps # god damn dvi and ps don't work
> 
> $(manual).en.xml: $(manual).xml
>       ln -sf $(manual).xml $@

Not a bad idea.

> 
> publish: all
>       test -d $(PUBLISHDIR)/$(manual) || install -d -m 755 
> $(PUBLISHDIR)/$(manual)
>       rm -f $(PUBLISHDIR)/$(manual)/*.html
>       @$(foreach fmt,.html .pdf .dvi .ps,\
>          $(foreach lang,$(LANGS),\
>            install -p -m 644 $(manual).$(lang).html $(PUBLISHDIR)/$(manual);\
>            install -p -m 644 $(manual).pdf $(PUBLISHDIR)/$(manual);\
>            install -p -m 644 $(manual).dvi $(PUBLISHDIR)/$(manual);\
>            install -p -m 644 $(manual).ps $(PUBLISHDIR)/$(manual)))

The problem here is that you only clean html files for an unknown
reason. I've cleaned it in the Makefile I commited.

Why do not you use $fmt instead of .pdf,.dvi. etc ?

publish: all
        test -d $(PUBLISHDIR)/$(manualdir) || install -d -m 755
$(PUBLISHDIR)/$(manualdir)
        rm -f $(PUBLISHDIR)/$(manualdir)/*.{html,pdf,dvi,ps}
        for built in $(manual); do \
        install -p -m 644 $$built.html $(PUBLISHDIR)/$(manualdir) ; \
        install -p -m 644 $$built.pdf $(PUBLISHDIR)/$(manualdir) ; \
        done


> validate:
>       xmllint --noout --loaddtd --catalogs $(sources)

With that rule you only validate the first file. Anyway I am unsure that
this rule is ran.

validate: $(sources)
        for checking in $(sources); do \
        xmllint --noout --loaddtd --catalogs $$checking ;\
        done


> html: $(foreach lang,$(LANGS),$(manual).$(lang).html)
> $(manual).%.html: $(manual).%.xml
>       xsltproc --catalogs -o $@ \
>       /usr/share/sgml/docbook/stylesheet/xsl/nwalsh/html/docbook.xsl \
>       $<

[...]

html:  $(addsuffix .html,$(manual))
%.html: %.xml
        xsltproc --catalogs -o $@ \
        /usr/share/sgml/docbook/stylesheet/xsl/nwalsh/html/docbook.xsl \
        $<


> clean_SUFFIXES :=  aux html dvi fo log pdf ps out toc
> 
> clean distclean:
>       rm -f $(addprefix $(manual).*.,$(clean_SUFFIXES))
>       rm -f *~ .*~ core tsa*
> 
My clean target is really dirty.
clean distclean:
        for removal in $(manual); do \
         rm -f $$removal.{aux,html,dvi,fo,log,pdf,ps,out,toc} ; \
        done
        rm -f *~ .*~ core tsa* ;


-- 
                                Pierre Machard
<[EMAIL PROTECTED]>                                 http://debian.org
GPG: 1024D/23706F87 : B906 A53F 84E0 49B6 6CF7 82C2 B3A0 2D66 2370 6F87

Attachment: signature.asc
Description: Digital signature

Reply via email to