On Sun, Sep 23, 2007 at 12:25:54PM +0300, Jari Aalto wrote:
> * Sun 2007-09-23 Frank Lichtenheld <djpig AT debian.org> INBOX
> Below new patch according to comment.
Looks much better.
> +my $ignore_tar_default_regexp = "
> +.[#~]*
> +*[#~]
> +'{arch}'
the quotes don't belong here.
> +.a
This should be *.a, shouldn't it?
Similar for .la, .o, .so, and .swp
> +.arch-ids
> +.arch-inventory
> +.bzr
> +.bzr.backup
> +.bzr.tags
> +.bzrignore
> +.cvsignore
> +.deps
> +.git
> +.gitignore
> +.hg
> +.la
> +.o
> +.shelf
> +.so
> +.svn
> +.swp
> +CVS
> +DEADJOE
> +RCS
> +_MTN
> +_darcs
> +";
What are the reasons for differences to the diff ignore default? I
understand the addition of .a, .o, and .so since these will cause errors
in diffs anyway but not for tars. But you at least left out the
tla/bazaar style temp directories (i.e. ',,*'). Any reason?
> +# Remove possible leading and trailing whitespace
> +$ignore_tar_default_regexp =~ s/\A\s+//;
> +$ignore_tar_default_regexp =~ s/\s+\Z//;
> +
> +# Remove possible comment lines; remove newllines to spaces
> +$ignore_tar_default_regexp =~ s/#*\s*[\r\n]+/ /gm;
I think if we use an array for the default, the rest of the code gets
much, much easier. I.e. @tar_ignore_default_regexp = qw'...';
Gruesse,
--
Frank Lichtenheld <[EMAIL PROTECTED]>
www: http://www.djpig.de/
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
