Raphael Hertzog <[EMAIL PROTECTED]> writes:
> severity 477954 normal
> thanks
>
> I'm CCing Joey who wrote the initial support for the git source package.
> He might want to provide his input and maybe even a patch. Release
> managers agreed to push changes/fixes in lenny for the new source package
> formats since they are not used in lenny at all.
>
> In response to Bug#477949:
>
> On Fri, 25 Apr 2008, Goswin Brederlow wrote:
>> I tried using the git format to proove a point and stumbled about
>> this. The dpkg-source manpage says that "-i" should ignore changes in
>> the working directory. But it doesn't:
>>
>> dpkg-source -i -ICVS -b reprepro-3.3.2
>> dpkg-source: info: using source format `3.0 (git)'
>> dpkg-source: error: uncommitted, not-ignored changes in working directory:
>> debian/changelog main.c
>> dpkg-buildpackage: failure: dpkg-source -i -ICVS -b reprepro-3.3.2 gave
>> error exit status 255
>> debuild: fatal error at line 1319:
>> dpkg-buildpackage -rfakeroot -D -us -uc -ICVS -i failed
>>
>> Further I think the dpkg-buildpackage manpage or the error message
>> should include that info (-i to ignore changes) more prominently. Like
>> "debuild" saying to use -d to override build-depends checking.
>
> You're confused "-i" doesn't ignore all changes but only those matching a
> specific regular expression. If you want to ignore some specific changes,
> then you have to modify that regular expression... which you didn't in
> that example.
>
>> Last but not least I would suggest that changes are not
>> ignored. Instead when building source a temporary commit should be
>> made, packaged and removed from the working directory again.
>
> The changes are not ignored... it's a design decision to fail if
> there are uncommitted changes. Thus I'm closing this bug.
>From man dpkg-source:
-i[regexp]
You may specify a perl regular expression to match files you
want filtered out of the list of files for the diff. (This list
is generated by a find command.) (If the source package is being
built as a version 3 source package using a VCS, this is instead
used to ignore uncommitted files.)
'this is instead used'. To me that clearly says dpkg will do the
ignoring automatically with "-i". A regexp can never say 'uncommited
file'.
As that is not the case I think this should be changed to
'(If the source package is being built as a version 3 source package
using a VCS, this can be used to ignore uncommitted files.)'
Maybe even add 'Using -i.* will ignore all uncommited files.'
And I still think the error message could hint at this option as it
will not be obvious for anyone unfamiliar with the git format.
MfG
Goswin
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
