El 22/06/08 05:15 Raphael Hertzog escribió: > Hi, > > On Sat, 21 Jun 2008, Felipe Sateler wrote: > > Attaching a version against current master (since this can't make it to > > lenny anyway). > > > > PS: an (N)ACK would be nice. > > We have received your patch.
Thanks for the response.
> Your patch would be even better if it was
> complete: please update the documentation of dpkg-buildpackage accordingly.
OK. This means editing man/dpkg-buildpackage.1?
> But I have some other remarks, see below.
>
> Last time we discussed this idea within the team, Frank wanted to
> handle it, but it's been a long time since we had this discussion. Frank,
> do you still have time/plans for this?
>
> > +my $source = Dpkg::Control->new()->get_source();
> > +if (defined($source->{"Build-Options"}) ) {
> > + # The build options are comma-separated, with optional spaces
> > + my @build_options = split( / *, */, $source->{"Build-Options"} );
>
> Please use "\s*,\s*".
>
> > + if( grep(/\bbuild-arch\b/, @build_options) && $binaryonly eq "-B") {
>
> Please match the keyword in its entirety: /^build-arch$/
Both done (locally, I will submit again when the documentation is done).
>
> > + $buildtarget = "build-arch";
> > + }
> > +}
>
> As we will probably add more Build-Options over time, we probably want to
> move this processing in a dedicated module... but we already have
> Dpkg::BuildOptions which handles DEB_BUILD_OPTIONS.
>
> I don't know if we want to put both in the same module or if we need to
> come up with a different name (or a sub-module maybe).
I can try doing this, although I couldn't find an appropriate name (perhaps
Source::BuildOptions?). The idea would be to add one function per build
option, or one function that processes them all? I think it's best to do one
function per build option, since an option can touch any part of the process.
>
> The discussion in the bug log also suggest to use Standards-Version as a
> source of implicit "build-options". If policy 4.0 mandates the build-arch
> target, then the simple fact that Standards-Version >= 4.0 can be assumed
> as having Build-Options: build-arch. I like this idea and would like to
> see it implemented in this patch.
This seems simple enough. I'll try doing this.
Saludos,
Felipe Sateler
signature.asc
Description: This is a digitally signed message part.
