Colin Watson schrieb am Wed 07. Jan, 18:52 (+0000):
> On Wed, Jan 07, 2009 at 06:42:37PM +0000, Chris Coulson wrote:
> > On Wed, 2009-01-07 at 18:35 +0100, Jörg Sommer wrote:
> > > Colin Watson schrieb am Wed 07. Jan, 12:18 (+0000):
> > > > diff -Nru dpkg-1.14.22ubuntu1/utils/start-stop-daemon.c
> > > > dpkg-1.14.22ubuntu2/utils/start-stop-daemon.c
> > > > --- dpkg-1.14.22ubuntu1/utils/start-stop-daemon.c 2008-08-26
> > > > 14:52:08.000000000 +0100
> > > > +++ dpkg-1.14.22ubuntu2/utils/start-stop-daemon.c 2008-12-10
> > > > 20:36:51.000000000 +0000
> > > > @@ -1221,6 +1236,12 @@
> > > > }
> > > > }
> > > >
> > > > +static inline int
> > > > +ioprio_set (int which, int who, int ioprio)
> > > > +{
> > > > + return syscall(SYS_ioprio_set, which, who, ioprio);
> > >
> > > Why don't you use ioprio_set() from the libc? Wouldn't be this much more
> > > safe for the future?
> >
> > I didn't realise that glibc provided wrapper's for either ioprio_set()
> > or ioprio_get(). If they do, then I agree that the patch should use the
> > glibc calls.
>
> I don't see any wrappers for this in glibc. (I'm looking at 2.9.)
> Perhaps Jörg was being optimistic? :-)Yes, I was to rashly^Woptimistic. I've looked at the output of strace, found a manpage for ioprio_set() and concluded there are functions in libc. But there are no such functions. You have to use syscall(). Bye, Jörg. -- Unsere Zweifel sind Verräter und oft genug verspielen wir den möglichen Gewinn, weil wir den Versuch nicht wagen.
signature.asc
Description: Digital signature http://en.wikipedia.org/wiki/OpenPGP
