On Thu, Nov 05, 2009 at 09:04:45PM +0100, Raphael Hertzog wrote:
> On Thu, 05 Nov 2009, Mike Hommey wrote:
> > A bit more information. It *hum*hum* works, actually, and the error
> > message above was due to remaining stuff in
> > debian/source/include-binaries.
> 
> No, it really doesn't work as expected. It works in lenny but doesn't work
> properly in sid. I think it might be due to a behavioural difference
> in perl's File::Find...
> 
> With --include-binaries if you should really get messages like this:
> dpkg-source: info: adding debian/test.png to debian/source/include-binaries
> and not:
> dpkg-source: info: adding ../test.png to debian/source/include-binaries
> 
> debian/source/include-binaries should contain paths relative to the root
> directory of the source package.
> 
> Effectively find() behaves differently but it's also due to a lack of a
> parameter that guaranteed that it would not change the current directory.
> So it's a bug of dpkg-source and not of File::Find.
> 
> That said, it should work for binaries outside of the debian directory as
> it's not the same code path and in that case I get proper messages.
> 
> Attached is the suggested patch. Tell me if you have other problems.

It seems to work properly with the patch. Would you know when this would
posible hit unstable ? ;)

Thanks,

Mike

PS: I do wonder, however, how dpkg-source can be *so much* slower than
tar -jxf ; diff -ruN (15 seconds for tar and 2 s for diff vs. 3'30 for
dpkg-source in quilt mode and 3' in format 1.0)




-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to