On Mon, 2010-05-31 at 17:19:50 +0200, Martin Pitt wrote: > Guillem Jover [2010-05-31 17:10 +0200]: > > Thanks for the patches! There's some stylistic problems, which I had > > already fixed in my pu/filters branch, as it seems you only took > > Tollef's commit, and others like copyright header matching the current > > ones, etc., but don't worry they are minor, I'm just amending them in. > > Hm, I thought I took the version from that branch's head, but if I > screwed up, sorry.
Oh! Don't worry about that, it was more the fact that you had to dupe some work that had already been done, when Raphaël pointed it out. I should have probably rebased it on top of current master so you'd have been able to use that directly. > > I'm also considering if --path-exclude and --path-include might be > > more appropriate, as the normal unit of operation for dpkg is a > > package and not a file/path. > > Ah, good point. I have no objection against renaming the options. I > guess you can trivially sed the patches? Or want me to provide updated > ones? Ok, perfect, and no, no need to resend. I'm just applying the patches with git-am, and then fixing some stuff, and doing “git commit --amend” which rewrites the current HEAD commit, preserving authorship and all that. thanks, guillem -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
