On Wed, 2012-05-16 at 21:00:47 +0100, Roger Leigh wrote: > On Wed, May 16, 2012 at 08:36:29PM +0200, Guillem Jover wrote: > > On Sun, 2011-11-13 at 22:42:49 +0000, Roger Leigh wrote: > > > New version attached. It includes your changes, plus the > > > documentation fixes you suggested. > > > > I've now come back to this and it indeed does make sense and looks sane. > > I've some comments below, that once fixed I'll be comfortable merging > > this for 1.16.4. > > Please find an updated patch. This is rebased against current > master with all conflicts resolved.
Cool, thanks! > > > >From fc2782bcdd940ebf61a47ce182cbdef7a469d62a Mon Sep 17 00:00:00 2001 > > > From: Roger Leigh <[email protected]> > > > Date: Sun, 13 Nov 2011 19:18:28 +0000 > > > Subject: [PATCH] Add Build-Depends-Arch and Build-Conflicts-Arch > > > +.TP > > > +.BI Build\-Conflicts: " package list" > > > +A list of packages that should not be installed when the package is > > > +built, for example because they interfere with the build system used. > > > +Including a dependency in this list has the same effect as including > > > +it in both Build-Conflicts-Arch and Build-Conflicts-Indep, with the > > > +additional effect of being used for source-only builds. This field > > > +was introduced in dpkg version 1.16.2; in order to build with older > > > +dpkg versions, \fBBuild\-Conflicts\fP should be used instead. > > > > The comment about it being introduced recently seems misplaced here. > > I've changed these to 1.16.4. This is intended to document the > version of dpkg introducing these fields, in case anyone needs to > build-depend on a version of dpkg >= this version. If this is > not necessary, or inappropriate, please feel free to delete these > lines. Ah, sorry for not being more clear, my point was that this would seem to belong in the description for Build-Conflicts-Arch (in line with the equivalent comment for Build-Depends-Arch) and not in the description for Build-Conflicts which is not the one recently introduced. Mentioning when this was introduced is certainly always desirable. thanks, guillem -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected]
