On Mon, 23 Dec 2013, Guillem Jover wrote: > > Doing this via a status fd would be nice[1] since we could then > > implement more nice things like progress information (we'd then be able > > to detect easily which dpkg-buildpackage's steps failed) without parsing > > the full build output. > > > [1] The status fd has the disadvantage that we need to pass it through > > tools like pbuilder and sbuild as well so a file at a well known > > location might be simpler. > > How do you see that progress information being used? Or to report > what?
Being able to programmatically detect in what step the failure happened is cleary useful, in particular for mass rebuilds. Differentiating failures in the source rebuild or the binary rebuild is already significant. > I'm not saying a --status-fd kind of option might not be useful, just > interested to know, if maybe there's something else that needs fixing > instead in dpkg-buildpackage, now that I'm reworking it. For example > if its error reporting leaves to be desired, then I'd rather improve > that, rather than adding support for wrappers to workaround it. :) > > For example for 1.17.6 I'm adding hooks support, which can be useful > for wrappers. Hooks are certainly useful but when dpkg-buildpackage is really wrapped in something much larger then it's somewhat counter-intuitive to have to include all the post-build processing in the final dpkg-buildpackage hook. I really believe that we ought to communicate back the generated changes file. > For the problem described in the bug report, I think a better way to > solve this is to run lintian directly from dpkg-buildpackage, which > will be possible with dpkg 1.17.6, by using the new check-command > support. See the following commit for further details: This is not so clear cut. Letting dpkg-buildpackage call lintian means that lintian must be installed in the build environment and that might not be the case in minimal build environment. You might want to call lintian outside of it (and thus outside of dpkg-buildpackage). > Or do you need the .changes file for something else? There a lots of things that you might want to do with a built package besides checking it: installing it for tests, uploading it, installing it in a repository, modifying it (in the case of dgit), etc. Cheers, -- Raphaël Hertzog ◈ Debian Developer Discover the Debian Administrator's Handbook: → http://debian-handbook.info/get/ -- To UNSUBSCRIBE, email to debian-dpkg-bugs-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
