Hi!
On Fri, 2014-11-14 at 19:01:49 +1100, Joshua Rogers wrote:
> Package: dpkg
> Version: 1.17.21-14-gc195
> Severity: normal
>
> (I hope I got that right this time!)
Yes. :)
> In dpkg-deb/info.c line 80:
> > dbuf = mkdtemp(path_make_temp_template("dpkg-deb"));
> In the
> path_make_temp_template([..]) function.
>
> dbuf is never freed.
> And:
> in dpkg-deb/extract.c
> > decompress_filter(decompressor, p1[0], p2_out,
> > _("decompressing archive member"));
> which calls
> > varbuf_vprintf(&desc, desc_fmt, args);
> which calls
> > varbuf_grow(v, needed + 1);
> WHICH CALLS....
> > v->buf = m_realloc(v->buf, v->size);
>
>
> is never freed.
These two are short-lived, they stop being used variables just before
the program terminates. I've fixed them locally targetting 1.18.x, out
of cleanliness, and because at least the second one coming from
libdpkg could impact external users, depending on how they use the
function.
On Fri, 2014-11-14 at 19:19:24 +1100, Joshua Rogers wrote:
> And just one more before I'm done...
>
> dpkg-deb/build.c
>
> > m= m_malloc(strlen(dir) + sizeof(DEBEXT));
> m is never freed.
I was aware of this one from the Coverity scan, but did not fix it yet
because it's also short-lived, as it stops being used just before
termination. But I'm fixing it also to stop showing up on similar tools.
Thanks,
Guillem
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
