Hi!

On Wed, 2015-02-04 at 14:40:45 +0200, Alex Potapenko wrote:
> Package: dpkg
> Version: 1.17.23
> Severity: minor

> While trying to cross-compile dpkg for an arm-uclibc target without
> sys_siglist,

Without sys_siglist nor strsignal()? Hmmm.

> I encountered the issue of failing to build libcompat due to
> wrong check for HAVE_DECL_SYS_SIGLIST value in lib/compat/strsignal.c. The
> line at fault reads "#ifndef HAVE_DECL_SYS_SIGLIST", while it should be
> "#if HAVE_DECL_SYS_SIGLIST == 0", since configure script writes "#define
> HAVE_DECL_SYS_SIGLIST 0" to config.h if check for sys_siglist fails. This
> is a minor issue, probably a typo, and an easy to fix one, but I thought
> you should probably be informed of this.

Please do keep filing any build failures of dpkg, even for non-Debian
Unix systems! I've applied the following change instead:

,---
diff --git a/lib/compat/strsignal.c b/lib/compat/strsignal.c
index 1f49701..265feb4 100644
--- a/lib/compat/strsignal.c
+++ b/lib/compat/strsignal.c
@@ -28,7 +28,7 @@
 
 #define _(str) gettext(str)
 
-#ifndef HAVE_DECL_SYS_SIGLIST
+#if !HAVE_DECL_SYS_SIGLIST
 const char *const sys_siglist[] = {
        NULL,           /* 0 */
        "SIGHUP",       /* 1 */
`---

Given that this is a build failure, I'm targetting the fix for 1.17.24.

Thanks,
Guillem


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to