Bug#827628: dpkg-source incorrectly simplfiies :native qualified build-dep

[Ben Hutchings]

Package: libdpkg-perl
Version: 1.18.7
Severity: important

Here's a patch; let me know if you need further justification.
The practical impact for me was that build-dependency:

    libssl-dev:native <!stage1>, libssl-dev <!stage1 !pkg.linux.notools cross>

was simplified to:

    libssl-dev <!stage1 !pkg.linux.notools cross>

and thus native builds had not dependency on libssl-dev.  (Of course,
there is a second bug here which is that the restrictions are not being
compared.)

Ben.

---
From: Ben Hutchings <b...@decadent.org.uk>
Date: Sat, 18 Jun 2016 22:49:06 +0100
Subject: _arch_qualifier_allows_implication: Unqualified does not imply :native

A missing architecture qualification means the host architecture,
whereas :native means the build architecture.  Neither implies the
other.
---
 scripts/Dpkg/Deps.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/Dpkg/Deps.pm b/scripts/Dpkg/Deps.pm
index cdd2587c56f4..42019254cca3 100644
--- a/scripts/Dpkg/Deps.pm
+++ b/scripts/Dpkg/Deps.pm
@@ -759,7 +759,7 @@ sub _arch_qualifier_allows_implication {
        return 1 if defined $q and ($p eq $q or $q eq 'any');
        return 0;
     } else {
-       return 0 if defined $q and $q ne 'any' and $q ne 'native';
+       return 0 if defined $q and $q ne 'any';
        return 1;
     }
 }


-- System Information:
Debian Release: stretch/sid
  APT prefers stable-updates
  APT policy: (500, 'stable-updates'), (500, 'unstable'), (500, 'stable'), (1, 
'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.6.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libdpkg-perl depends on:
ii  dpkg  1.18.7
ii  perl  5.22.2-1

Versions of packages libdpkg-perl recommends:
ii  bzip2                   1.0.6-8
ii  libfile-fcntllock-perl  0.22-3+b1
ii  xz-utils                5.1.1alpha+20120614-2.1

Versions of packages libdpkg-perl suggests:
ii  binutils              2.26-11
ii  debian-keyring        2016.04.22
ii  gcc [c-compiler]      4:5.3.1-3
ii  gcc-4.8 [c-compiler]  4.8.5-4
ii  gcc-5 [c-compiler]    5.4.0-4
ii  gnupg                 1.4.20-6
ii  gnupg2                2.1.11-7
ii  gpgv                  1.4.20-6
ii  patch                 2.7.5-1

-- no debconf information

-- debsums errors found:
debsums: changed file /usr/share/perl5/Dpkg/Deps.pm (from libdpkg-perl package)