Package: dpkg-dev
Version: 1.18.9
Severity: wishlist
User: [email protected]
Usertags: toolchain buildpath
X-Debbugs-Cc: [email protected]

Dear dpkg maintainers,

Over the past month we've been rebuilding the debian archive with
'-fdebug-prefix-map' (also known as 'reproducible/fixdebugpath' within
dpkg-buildflags) enabled.

Following the dpkg team's instructions [0] about how to add a new
buildflag to the default set we wrote to debian-devel [1][2] exposing
our findings and our believes.

Summing up, according to our tests enabling this build flags is going to
cause 4 FTBFS in unstable:
 - afl #828178
 - libblocksruntime #832015
 - libclc # 832014
 - ncl #832011

Is my personal opinion that none of these packages warrant delaying the
introduction of this build flag in the default set.
Besides, nobody raised any concern after those emails to d-d.

Therefore, we'd like to proceed.  Attached you can find a patch enabling
the buildflags set reproducible/fixdebugpath by default.

Thanks in advance.


[0] 
https://wiki.debian.org/Teams/Dpkg/FAQ#Q:_Can_we_add_support_for_new_default_build_flags_to_dpkg-buildflags.3F
[1] 
https://lists.debian.org/msgid-search/[email protected]
[2] 
https://lists.debian.org/msgid-search/[email protected]

-- 
regards,
                        Mattia Rizzolo

GPG Key: 66AE 2B4A FCCF 3F52 DA18  4D18 4B04 3FCD B944 4540      .''`.
more about me:  https://mapreri.org                             : :'  :
Launchpad user: https://launchpad.net/~mapreri                  `. `'`
Debian QA page: https://qa.debian.org/developer.php?login=mattia  `-
From 16764bc196592b3eaed5002db08022b3446ca316 Mon Sep 17 00:00:00 2001
From: Mattia Rizzolo <[email protected]>
Date: Sat, 23 Jul 2016 10:25:22 +0000
Subject: [PATCH] enable reproducible/fixdebugpath build flag by default.

---
 man/dpkg-buildflags.1         | 2 +-
 scripts/Dpkg/Vendor/Debian.pm | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/man/dpkg-buildflags.1 b/man/dpkg-buildflags.1
index ab79ad5..cb157c9 100644
--- a/man/dpkg-buildflags.1
+++ b/man/dpkg-buildflags.1
@@ -411,7 +411,7 @@ This will cause warnings when the \fB__TIME__\fP, \fB__DATE__\fP and
 .
 .TP
 .B fixdebugpath
-This setting (disabled by default) adds
+This setting (enabled by default) adds
 .BI \%\-fdebug\-prefix\-map= BUILDPATH =.
 to \fBCFLAGS\fP, \fBCXXFLAGS\fP, \fBOBJCFLAGS\fP, \fBOBJCXXFLAGS\fP,
 \fBGCJFLAGS\fP, \fBFFLAGS\fP and \fBFCFLAGS\fP where \fBBUILDPATH\fP is
diff --git a/scripts/Dpkg/Vendor/Debian.pm b/scripts/Dpkg/Vendor/Debian.pm
index 29aeece..ebb1750 100644
--- a/scripts/Dpkg/Vendor/Debian.pm
+++ b/scripts/Dpkg/Vendor/Debian.pm
@@ -158,7 +158,7 @@ sub _add_reproducible_flags {
     # Default feature states.
     my %use_feature = (
         timeless => 1,
-        fixdebugpath => 0,
+        fixdebugpath => 1,
     );
 
     my $build_path;
-- 
2.8.1

Attachment: signature.asc
Description: PGP signature

Reply via email to