Your message dated Fri, 11 Nov 2016 03:03:50 +0000
with message-id <[email protected]>
and subject line Bug#843829: fixed in dpkg 1.18.14
has caused the Debian Bug report #843829,
regarding dpkg-parsechangelog incorrectly claims May is only a 'full' month on 
date parse failure
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)


-- 
843829: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=843829
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Package: dpkg
Version: 1.18.10ubuntu1
Severity: important
Tags: patch

Dear Maintainer,

Running dpkg-parsechangelog on changelogs that produce date parsing
problems, e.g.:

Tue, 17 May 2008 10:93:55 -0500

(don't ask me how it got there, but it happened in one Ubuntu publish).

ends up with an error like, "uses full instead of abbreviated month name
'May'", which is obviously not the actual problem. I think there is
actually a bug in dpkg (introduced in:
https://anonscm.debian.org/cgit/dpkg/dpkg.git/commit/scripts/Dpkg/Changelog/Entry/Debian.pm?id=21f5898d846a1cd69bdc6849e2097168cde02fdf),
in that if a full month is found to be used, it's not checked that the
full month is *also* an abbreviated month (only true for May, though).

I tested a fix with below patch on my local system. It feels like it
might be cleaner to special-case May as the only affected month, but I
think the logic was simply incorrect before either way -- it only makes
sense to check if a full month was used if an abbreviated month wasn't.

Thanks,
Nish

--- /usr/share/perl5/Dpkg/Changelog/Entry/Debian.pm.bak 2016-11-02 
17:07:08.195115132 -0700
+++ /usr/share/perl5/Dpkg/Changelog/Entry/Debian.pm     2016-11-02 
17:08:14.020173675 -0700
@@ -226,11 +226,13 @@ sub parse_trailer {
            # Validate the month. Date::Parse used to accept both abbreviated
            # and full months, but Time::Piece strptime() implementation only
            # matches the abbreviated one with %b, which is what we want anyway.
-           if (exists $month_name{$8}) {
-               push @errors, sprintf(g_('uses full instead of abbreviated 
month name \'%s\''),
-                                     $8, $month_name{$8});
-           } elsif (not exists $month_abbrev{$8}) {
-               push @errors, sprintf(g_('invalid abbreviated month name 
\'%s\''), $8);
+           if (not exists $month_abbrev{$8}) {
+                if (exists $month_name{$8}) {
+                   push @errors, sprintf(g_('uses full instead of abbreviated 
month name \'%s\''),
+                                         $8, $month_name{$8});
+                } else {
+                   push @errors, sprintf(g_('invalid abbreviated month name 
\'%s\''), $8);
+                }
            }
            push @errors, sprintf(g_("cannot parse non-comformant date '%s'"), 
$7);
        };


-- 
Nishanth Aravamudan
Ubuntu Server
Canonical Ltd

--- End Message ---
--- Begin Message ---
Source: dpkg
Source-Version: 1.18.14

We believe that the bug you reported is fixed in the latest version of
dpkg, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Guillem Jover <[email protected]> (supplier of updated dpkg package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Fri, 11 Nov 2016 02:26:08 +0100
Source: dpkg
Binary: dpkg libdpkg-dev dpkg-dev libdpkg-perl dselect
Architecture: source
Version: 1.18.14
Distribution: unstable
Urgency: medium
Maintainer: Dpkg Developers <[email protected]>
Changed-By: Guillem Jover <[email protected]>
Description:
 dpkg       - Debian package management system
 dpkg-dev   - Debian package development tools
 dselect    - Debian package management front-end
 libdpkg-dev - Debian package management static library
 libdpkg-perl - Dpkg perl modules
Closes: 843791 843826 843829 843874
Changes:
 dpkg (1.18.14) unstable; urgency=medium
 .
   [ Guillem Jover ]
   * Improve PIE flags support:
     - Rename the spec name cc1_options to self_spec.
       Suggested by James Clarke <[email protected]>
     - Do not set PIE options if they have been negated, and do not reset
       them if they have been requested.
     Closes: #843791, #843826
   * Fix use after free error in dpkg. It was trying to print messages that
     had already been freed as part of the database memory pool, causing in
     some cases segfaults when reporting the error summary at the end.
     Regression introduced in dpkg 1.18.11. Closes: #843874
   * Change default color behavior to auto.
   * Perl modules:
     - Fix confusing date parse error message in Dpkg::Changelog::Entry::Debian
       when the date contains “May”. Closes: #843829
       Thanks to Nishanth Aravamudan <[email protected]>.
     - New module Dpkg::Build::Info module refactored from dpkg-genbuildinfo.
       Requested by Johannes Schauer <[email protected]>.
   * Documentation:
     - Improve the DEB_BUILD_OPTIONS description in dpkg-buildpackage(1).
       And mention the parallel option there.
     - Explicitly mention in dpkg-buildpackage(1) that setting the number
       of parallel jobs to 1, restores the serial behavior.
       Prompted by Thorsten Glaser <[email protected]>.
   * Packaging:
     - List public Dpkg::Control::Tests module in libdpkg-perl description.
   * Test suite:
     - Do not fail tests on missing fakeroot, just skip them.
   * Build system:
     - Fix inversion logic in libmd configure check when requested explicitly.
     - Do not consider the compressor libraries available in configure if the
       headers are not usable.
     - Fix DPKG_BUILD_RELEASE_DATE to require DPKG_PROG_PERL, as it uses perl.
     - Change DPKG_BUILD_RELEASE_DATE to use perl instead of date(1) to
       format the timestamp, as the former is more portable.
 .
   [ Updated man pages translations ]
   * German (Helge Kreutzmann).
Checksums-Sha1:
 6525f0885e2ddb34c1fcb227e5ce57a3f4ba126c 2032 dpkg_1.18.14.dsc
 3e4e6799ee50a3a3215d84813482ca5f50d15bb1 4492628 dpkg_1.18.14.tar.xz
Checksums-Sha256:
 4a99c85a57fec5892f91ddfce65858f8d37bbc3f4afa6e63cf456183530f2982 2032 
dpkg_1.18.14.dsc
 1788e418526049097fb3d8f68d5a75053c19693ab1fa47a506a7ef80db454d5a 4492628 
dpkg_1.18.14.tar.xz
Files:
 3adcbd0ff4b1d1cc5bb6deb519978bba 2032 admin required dpkg_1.18.14.dsc
 f8f86236d9c52785b26b0f831d09975e 4492628 admin required dpkg_1.18.14.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEETz509DYFDBD1aWV0uXK/PqSuV6MFAlglLv4ACgkQuXK/PqSu
V6Oe0w/9EA0Z+71Orpgsj4Fo3W9gqbcYkCllPcusD7aeOHW1CvXN12d2PRLAqZ5+
Kg7yqkbxrNG77THSd93Lf9sEAd8fZX4Idas0Hgyd+FK0ElQVUW+F70HYl+oGs/xd
BB+viQ82aoWgpQlYuQsy7b+GYeVK5JWHpdmFVv9Ens6JLGWNSnkDmYTke1WWSgk/
VJ/+lIcFa78O27gh6AHL+zK3tIVtdTQToQxNYyvavQHR7fpg5Y52UhxqUFc8pGd/
TPjhWq8j7Ax/b9Y7WfIfJj8i4oknRxS2zK3dYcb7XEQxxjiMDJFqBwa8UGMm9phL
9Vt6eTDjQJ0OwOyuYYtKgJMU5zlSEKn1WLRdDVGihjU4trrSaQhDnJ1DQYTjiu40
E98Spa+LPmDclditG2KHm1UzZCkazExX8XN716Y26gVCoPnY1zfFOI6pIZrTOZo7
ONwlI5AsJ2Z788boV3vt/wvXoMHwK7UQAozWafUVgS/uAHmymmBSs+RpAvxGWTqN
MNviRl5LhCh3bLCMx+Qy3dHPRRs5o7N2uKxVZzmptFiIGeDTKi1IEmGYRaCotRT7
q0XXdKEfhNmCu+tfRK0A/5OCgZ5X5sTrbjyowTM9AEG48W0Okcgq4yyrTUU91HQk
NZWof9vtGgE7eOQT4IMpm/9TsqLbfr9wu3n3pED1BiCihKwt8sg=
=a9+4
-----END PGP SIGNATURE-----

--- End Message ---

Reply via email to