Hi! On Thu, 2018-09-13 at 12:03:09 +0100, Ian Jackson wrote: > Package: dpkg-dev > Version: 1.19.0.5 > Control: block 908417 by -1
> Recently a dgit user complained that if their package has a tar-ignore > in debian/source/options, things go wrong. See #908417. > > dgit needs to run dpkg-source in such a way that all things in the > input directory end up in the source package, except precisely the > top-level .git directory. To do this it passes a slew of -I and -i > options to dpkg-source. > > But if the source package contains a tar-ignore option in > debian/source/options, this does not work, because the -I options > stack up. > > Simply having the user remove tar-ignore from the source package's > debian/source/options is IMO best, but as you see in #908417 that does > have downsides. > > If dpkg-source provided a --reset-tar-ignore option which cancelled > all previous --tar-ignore options (including those from > debian/source/options), then dgit could pass that option and > everything would work right. Hmm, I found this bug description and the problem from the referenced bug to be a bit of a mismatch. I checked the notmuch referenced history where I noticed in commit 514fb397c9f7cfc80f0b14bd28bb2acdb4cd30ca that the problem was the standalone tar-ignore option. The current options file now contains: ,--- debian/source/options single-debian-patch tar-ignore=.git tar-ignore=performance-test/download/*.tar.xz `--- With that in mind, I'm not sure whether your request is to ignore *only* those standalone tar-ignore options or any of them regarldess of these taking an argument or not? Because I'd think in general you'd want to honor the ignore rules from the source package itself, except for the dpkg-source defaults. OTOH I guess those same ignores would be covered by things such as .gitignore or similar VCS-specific files. I think both options, never-add-tar-ignore-defaults-even-if-specified and clear-all-tar-ignore are valid, and I might add both, just wanted to make sure I understand which one you are requesting here. Thanks, Guillem
