On 2019-02-07 Guillem Jover <[email protected]> wrote: > On Wed, 2019-02-06 at 19:58:52 +0100, Andreas Metzler wrote: [...] >> dpkg's changelog.Debian says: >> * start-stop-daemon: Check whether standalone --pidfile use is secure. >> Prompted by Michael Orlitzky <[email protected]>.
>> the regular changelog is more verbose: [...] >> However the manpage was not updated. Could you please describe which >> restrictions were added, what behavior I can rely on to work? > The man page had been updated in a previous release (1.19.1): > ,--- > commit 7afd25e72f447a4a4b130f38bba28ff6661cbb6c > Author: Guillem Jover <[email protected]> > Date: Fri Sep 14 21:35:16 2018 +0200 > man: Add a warning in s-s-d(8) about using --pidfile alone with non-root > files [...] > Is that not enough? Hello, Imho no. It warns that this is dangerous, while it actually *was* dangerous up to 1.19.1 and *is* non-functional now, since s-s-d will refuse to act and will not kill the process but exit with an error instead. There should be something like "If -pidfile is not used in combination with x, y, z and the pidfile is not owned by root than ssd (version 1.19.2 and later) will exit with an error instead of kiling the process." I diffed 1.19.1 and 1.19.3 manpages and searched in vain for the description of a behavior change. :-( >> For further entertainment exim does not use start-stop-daemon directly >> but uses lsb, which seems to translate >> killproc -p /run/exim4/exim.pid /usr/sbin/exim4 >> to >> /sbin/start-stop-daemon --stop --retry 5 --quiet --pidfile >> /run/exim4/exim.pid >> dropping the daemon name somewhere. > Hrrm, given that lsb is pretty much abandoned, and the maintainer has > stated in the past little interest in touching the sysvinit script > parts, it might be quickest perhaps to switch to use s-s-d directly? I have done that. >> I would appreciate if you could agree to keep this dpkg update put of >> testing a little bit to be able to solve this. > I was planning a new upload during this week (the version in sid, will > not migrate as is due to a regression in dgit's autopkgtests), but can > postpone it a few days until you've uploaded exim. Thanks for the offer, I have just uploaded a fix for exim, so it will not be necessary. Thanks for maintaining dpkg, BTW! cu Andreas -- `What a good friend you are to him, Dr. Maturin. His other friends are so grateful to you.' `I sew his ears on from time to time, sure'
signature.asc
Description: PGP signature
