Control: severity -1 wishlist

Hi!

On Thu, 2019-05-23 at 18:20:05 +0530, Pirate Praveen wrote:
> package: dpkg
> severity: important
> version: 1.19.6

> For example node-gulp package depend on "object.defaults" node module.
> But when running dpkg-source -b . with node-gulp_4.0.4.orig-object.defaults
> present in parent directory, the dsc file created does not include this
> module.

This works as documented. There are two different separators here, the
underscore to split between the upstream name and the version, and
then the dots after .orig to distinguish the extensions. Accepting
dots in the component might make future extensions ambiguous. I'd
rather not change this TBH.

> uscan -dd will create the module correctly.

I'd say, uscan is actually not creating the modules correctly, if it's
not following the documented format. :)

> This means we will have to change component name to object-defaults and
> then in rules rename it back to object.defaults.

You could simply symlink them instead?

> I hope this can be fixed.

I think I'd rather not change the current behavior. But I guess could
perhaps be otherwise convinced with solid arguments. Otherwise I'm
planning on marking this wontfix and close in a bit.


Thinking about this a bit more, I guess one option could be to make
dpkg-source map these automatically. Say after #577113 is implemented,
you'd list the component there as «foo.bar», and then dpkg-source
would know to look for «.orig-foo-bar.» and then unpack as «foo.bar».
I guess that would solve your problem w/o needing to change the
accepted filename pattern. It would still be backwards incompatible
though.

Thanks,
Guillem

Reply via email to