Hi!
On Tue, 2023-12-19 at 23:33:47 -0800, Steve Langasek wrote:
> On Sun, Jul 09, 2023 at 08:06:56PM +0200, Guillem Jover wrote:
> > I realized now that this cannot be set for CXXFLAGS as at least g++
> > will warn about that. And I've gone for now by depending on qa=+bug,
> > but I'm not sure whether that would cause too many regressions. OTOH
> > and AFAIK any such problem should be considered a genuine bug anyway,
> > so…
>
> > But if this is too much I guess I could split that warning into its
> > own feature and make both the qa=+bug and abi=+time64 depend on it
> > instead.
>
> Now that I've had a chance to look at the implementation, I am concerned
> about abi=+time64 implying qa=+bug, because I see that this turns on
> additional -Werror options beyond implicit-function-declaration:
>
> my @cfamilyflags = qw(
> array-bounds
> clobbered
> volatile-register-var
> );
> foreach my $warnflag (@cfamilyflags) {
> $flags->append('CFLAGS', "-Werror=$warnflag");
> $flags->append('CXXFLAGS', "-Werror=$warnflag");
> }
>
> While these may all be bugs, forcing the fixing of bugs unrelated to the
> time_t transition during the transition will inevitably slow down Debian
> development, so I am concerned about having such a dependency. We
> unfortunately also haven't done any archive rebuild analysis on this to
> understand how large the actual impact is (again, the focus has been on just
> getting the analysis right of which packages do have an ABI change).
>
> And while there's no specific timeline required on the Debian side yet, on
> the Ubuntu side we have a tight timeline to get this all done in the next
> couple of months so that it can be included in the 24.04 LTS release.
>
> The idea of splitting it into a separate feature seems ok, to avoid turning
> on unrelated -Werror options.
Ok, I'll prepare a patch this week to split it then.
> We still don't have a slot from the Release Team for when this can be
> landed, but following up to debian-devel with a complete analysis of the
> library ABIs is my next step before the end of year. Is this a change you
> think could be uploaded to dpkg on short notice? Or would you be amenable
> to an NMU, if you're unavailable for an upload?
Once the discussion is settled and the plan agreed, I think that will
also include agreeing on a date for all the involved uploads. TBH, I
don't expect that to be on short notice given all the parties that
might need to coordinate this, but I have no problem planning and
preparing an upload for a specific pre-agreed date. (And in case that
for some weird reason it would end up being on short notice I should
be able to manage too, I guess. :)
I also assume that with "this change" you refer to flipping the default
plus the -Werror flag stuff and not just the latter.
Regards,
Guillem
