Author: guillem
Date: 2007-05-20 23:53:24 +0000 (Sun, 20 May 2007)
New Revision: 783
Modified:
trunk/ChangeLog
trunk/debian/changelog
trunk/scripts/dpkg-statoverride.pl
Log:
Remove an unused variable in dpkg-statoverride by renaming it to the
initially indented name. Closes: #425041
Modified: trunk/ChangeLog
===================================================================
--- trunk/ChangeLog 2007-05-17 00:40:37 UTC (rev 782)
+++ trunk/ChangeLog 2007-05-20 23:53:24 UTC (rev 783)
@@ -1,3 +1,9 @@
+2007-05-21 Guillem Jover <[EMAIL PROTECTED]>
+
+ * scripts/dpkg-statoverride.pl ($pat): Rename to ...
+ ($pattern): ... this. Fixes $pattern being an unused variable.
+ ($file): Move the declaration to its first usage in the for loop.
+
2007-05-15 Guillem Jover <[EMAIL PROTECTED]>
* configure.ac: Bump version to 1.14.4~.
Modified: trunk/debian/changelog
===================================================================
--- trunk/debian/changelog 2007-05-17 00:40:37 UTC (rev 782)
+++ trunk/debian/changelog 2007-05-20 23:53:24 UTC (rev 783)
@@ -1,6 +1,8 @@
dpkg (1.14.4) UNRELEASED; urgency=low
- *
+ [ Guillem Jover ]
+ * Remove an unused variable in dpkg-statoverride by renaming it to the
+ initially indented name. Closes: #425041
-- Guillem Jover <[EMAIL PROTECTED]> Tue, 15 May 2007 16:35:25 +0300
Modified: trunk/scripts/dpkg-statoverride.pl
===================================================================
--- trunk/scripts/dpkg-statoverride.pl 2007-05-17 00:40:37 UTC (rev 782)
+++ trunk/scripts/dpkg-statoverride.pl 2007-05-20 23:53:24 UTC (rev 783)
@@ -167,8 +167,8 @@
$dowrite=1;
print(STDERR _g("warning: --update is useless for --remove")."\n") if
($doupdate);
} elsif ($mode eq "list") {
- my (@list,@ilist,$pattern,$file);
-
+ my (@list, @ilist);
+
@ilist= @ARGV ? @ARGV : ('*');
while (defined($_=shift(@ilist))) {
s/\W/\\$&/g;
@@ -177,10 +177,11 @@
s,/+$,, && print STDERR _g("stripping trailing /")."\n";
push(@list,"^$_\$");
}
- my $pat = join('|', @list);
+
+ my $pattern = join('|', @list);
$exitcode=1;
- for $file (keys %owner) {
- next unless ($file =~ m/$pat/o);
+ for my $file (keys %owner) {
+ next unless ($file =~ m/$pattern/o);
$exitcode=0;
print "$owner{$file} $group{$file} $mode{$file} $file\n";
}
--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
