The following commit has been merged in the master branch:
commit d610bdbe994be8170b791e56665443e1591eefd1
Author: Guillem Jover <[email protected]>
Date: Thu Jan 3 01:03:26 2013 +0100
scripts/t/200_Dpkg_Shlibs.t: Use semicolon instead of comma
Fixes ValuesAndExpressions::ProhibitCommaSeparatedStatements.
Warned-by: perlcritic
diff --git a/scripts/t/200_Dpkg_Shlibs.t b/scripts/t/200_Dpkg_Shlibs.t
index 2072e20..99e5073 100644
--- a/scripts/t/200_Dpkg_Shlibs.t
+++ b/scripts/t/200_Dpkg_Shlibs.t
@@ -483,7 +483,7 @@ is_deeply(\@tmp, [], 'but old style wildcard is not LOST.');
# 'Internal' pattern covers all internal symbols
load_patterns_obj();
@tmp = grep { $_->get_symbolname() =~ /Internal/ }
$sym_file->get_symbols('libpatterns.so.1');
-$sym =
$sym_file->create_symbol('(regex|c++)^_Z(T[ISV])?N3NSA6ClassA8Internal.*@Base$
1.internal'),
+$sym =
$sym_file->create_symbol('(regex|c++)^_Z(T[ISV])?N3NSA6ClassA8Internal.*@Base$
1.internal');
$pat = $sym_file->lookup_pattern($sym, 'libpatterns.so.1');
is_deeply ([ sort $pat->get_pattern_matches() ], [ sort @tmp ],
'Pattern covers all internal symbols');
@@ -510,7 +510,7 @@ is_deeply( [ sort map { $_->get_symbolname() }
$pat->get_pattern_matches() ],
ok( ($pat->get_pattern_matches())[0]->is_optional(),
'private symbol is optional like its pattern');
ok( $sym_file->lookup_symbol(($pat->get_pattern_matches())[0],
'libpatterns.so.1'),
- 'lookup_symbol() finds symbols matched by pattern (after merge)'),
+ 'lookup_symbol() finds symbols matched by pattern (after merge)');
# Get rid of a private symbol, it should not be lost
delete $obj->{dynsyms}{$private_symnames[0]};
@@ -538,7 +538,7 @@ is( $pat->{deprecated}, '100.MISSING',
# Internal symbols. All covered by the pattern?
@tmp = grep { $_->get_symbolname() =~ /Internal/ } values
%{$sym_file->{objects}{'libpatterns.so.1'}{syms}};
-$sym =
$sym_file->create_symbol('(regex|c++)^_Z(T[ISV])?N3NSA6ClassA8Internal.*@Base$
1.internal'),
+$sym =
$sym_file->create_symbol('(regex|c++)^_Z(T[ISV])?N3NSA6ClassA8Internal.*@Base$
1.internal');
$pat = $sym_file->lookup_pattern($sym, 'libpatterns.so.1');
is_deeply ([ sort $pat->get_pattern_matches() ], [ sort @tmp ],
'Pattern covers all internal symbols');
diff --git a/test/100_critic.t b/test/100_critic.t
index 2bdec14..87b0f05 100644
--- a/test/100_critic.t
+++ b/test/100_critic.t
@@ -74,6 +74,7 @@ my @policies = qw(
TestingAndDebugging::ProhibitNoWarnings
TestingAndDebugging::RequireUseStrict
TestingAndDebugging::RequireUseWarnings
+ ValuesAndExpressions::ProhibitCommaSeparatedStatements
ValuesAndExpressions::ProhibitComplexVersion
ValuesAndExpressions::ProhibitInterpolationOfLiterals
ValuesAndExpressions::ProhibitLongChainsOfMethodCalls
--
dpkg's main repository
--
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]
