The following commit has been merged in the master branch:
commit 7f00d62776f201cb7415375c6c90f745a1f2cb30
Author: Pablo Oliveira <[email protected]>
Date:   Wed May 29 14:37:43 2013 +0200

    Dpkg::Source::Quilt: Fix chmod() arguments order
    
    In the restore_quilt_backup_files() function, the chmod() call has the
    arguments swapped. This prevents restoring quilt patches that remove
    files.
    
    Closes: #710265
    
    Signed-off-by: Guillem Jover <[email protected]>

diff --git a/debian/changelog b/debian/changelog
index 3bca159..a11b7f1 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -133,6 +133,8 @@ dpkg (1.17.0) UNRELEASED; urgency=low
     as a user-friendly frontend.
   * Remove temporary file on error during «dpkg-divert --rename».
   * Fix value caching in Dpkg::Arch by not shadowing the variables.
+  * Fix chmod() arguments order in Dpkg::Source::Quilt. Closes: #710265
+    Thanks to Pablo Oliveira <[email protected]>.
 
   [ Raphaël Hertzog ]
   * Fix dpkg-maintscript-helper rm_conffile and mv_conffile to do nothing
diff --git a/scripts/Dpkg/Source/Quilt.pm b/scripts/Dpkg/Source/Quilt.pm
index fb42cb5..2739ecc 100644
--- a/scripts/Dpkg/Source/Quilt.pm
+++ b/scripts/Dpkg/Source/Quilt.pm
@@ -294,7 +294,7 @@ sub restore_quilt_backup_files {
                 unless (link($_, $target)) {
                     copy($_, $target) ||
                         syserr(_g('failed to copy %s to %s'), $_, $target);
-                    chmod($target, (stat(_))[2]) ||
+                    chmod((stat(_))[2], $target) ||
                         syserr(_g("unable to change permission of `%s'"), 
$target);
                 }
             } else {

-- 
dpkg's main repository


-- 
To UNSUBSCRIBE, email to [email protected]
with a subject of "unsubscribe". Trouble? Contact [email protected]

Reply via email to