This is an automated email from the git hooks/post-receive script. guillem pushed a commit to branch master in repository dpkg.
View the commit online: https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=3d4afe2967eccd7805d067a3eab6938f7f099a63 commit 3d4afe2967eccd7805d067a3eab6938f7f099a63 Author: Guillem Jover <[email protected]> AuthorDate: Mon Jul 30 04:31:32 2018 +0200 Dpkg::Deps::KnownFacts: Rename _evaluate_simple_dep to evaluate_simple_dep This method is currently used by Dpkg::Deps::Simple, and is marked as private by way of its underscore prefix. This will be a problem once we split the modules into different files, as then we are not supposed to be using private methods from external modules. Rename the method, and document it explicitly as being private, while only giving a partial prototype to deter its use. --- scripts/Dpkg/Deps.pm | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/scripts/Dpkg/Deps.pm b/scripts/Dpkg/Deps.pm index d6c90cf77..613ca2d7a 100644 --- a/scripts/Dpkg/Deps.pm +++ b/scripts/Dpkg/Deps.pm @@ -961,7 +961,7 @@ is lacking to conclude. sub get_evaluation { my ($self, $facts) = @_; return if not defined $self->{package}; - return $facts->_evaluate_simple_dep($self); + return $facts->evaluate_simple_dep($self); } =item $dep->simplify_deps($facts, @assumed_deps) @@ -1726,7 +1726,13 @@ sub _find_virtual_packages { return @{$self->{virtualpkg}{$pkg}}; } -sub _evaluate_simple_dep { +=item $facts->evaluate_simple_dep() + +This method is private and should not be used except from within Dpkg::Deps. + +=cut + +sub evaluate_simple_dep { my ($self, $dep) = @_; my ($lackinfos, $pkg) = (0, $dep->{package}); my $p = $self->_find_package($dep, \$lackinfos); -- Dpkg.Org's dpkg
