This is an automated email from the git hooks/post-receive script.

guillem pushed a commit to branch master
in repository dpkg.

View the commit online:
https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=e50f4c72b02a88a0124d0f2b671185504fea90cd

commit e50f4c72b02a88a0124d0f2b671185504fea90cd
Author: Guillem Jover <[email protected]>
AuthorDate: Wed Aug 8 11:07:41 2018 +0200

    debian: Do not pass VERBOSE to test suite
    
    The VERBOSE variable is only honored when using the automake test
    drivers, which we are not using, not even the custom ones. Remove
    the variable usage which is confusing as it is not doing anything.
---
 .gitlab-ci.yml   | 4 ++--
 debian/changelog | 2 ++
 debian/rules     | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index f36669fd1..4dea92ec4 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -27,7 +27,7 @@ unit-tests:
       libtest-pod-perl libtest-pod-coverage-perl libtest-spelling-perl
       libtest-synopsis-perl
     - ./configure
-    - make check VERBOSE=1 TESTSUITEFLAGS=--verbose TEST_PARALLEL=$(nproc)
+    - make check TESTSUITEFLAGS=--verbose TEST_PARALLEL=$(nproc)
                  AUTHOR_TESTING=1
 
 # Test whether the unit tests pass on a VPATH build.
@@ -37,7 +37,7 @@ vpath-tests:
     - mkdir -p build-tree
     - cd build-tree
     - ../configure
-    - make check VERBOSE=1 TESTSUITEFLAGS=--verbose TEST_PARALLEL=$(nproc)
+    - make check TESTSUITEFLAGS=--verbose TEST_PARALLEL=$(nproc)
 
 # Test whether the external functional tests pass.
 func-tests:
diff --git a/debian/changelog b/debian/changelog
index 6e5cf8bc4..cbf5b364c 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -196,6 +196,8 @@ dpkg (1.19.1) UNRELEASED; urgency=medium
       suite, but shadowed by dpkg-dev from the build system pulling those in.
     - Add versioned libncurses-dev as the first Build-Depends alternative.
       Thanks to Sven Joachim <[email protected]>.
+    - Do not pass VERBOSE to test suite, as we are not using any automake
+      test driver, so it does not get honored.
   * Test suite:
     - Skip Dpkg::OpenPGP test if gpg is not present.
     - Check POD in all perl scripts.
diff --git a/debian/rules b/debian/rules
index 6099c5c10..22052b892 100755
--- a/debian/rules
+++ b/debian/rules
@@ -83,7 +83,7 @@ check: build
        dh_testdir
 
 ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
-       cd build-tree && $(MAKE) VERBOSE=1 TESTSUITEFLAGS=--verbose \
+       cd build-tree && $(MAKE) TESTSUITEFLAGS=--verbose \
                                 TEST_PARALLEL=$(NUMJOBS) check
 endif
 

-- 
Dpkg.Org's dpkg

Reply via email to