This is an automated email from the git hooks/post-receive script. guillem pushed a commit to branch master in repository dpkg.
View the commit online: https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=c3808237c6be5316d170aa928dd755390b667af9 commit c3808237c6be5316d170aa928dd755390b667af9 Author: Guillem Jover <[email protected]> AuthorDate: Wed Mar 27 03:12:04 2019 +0100 scripts: Switch Getopt::Long from bundling to bundling_values This got introduced after a request so that we could switch our tools to a safe subset of the bundling logic, so let's enable it now that it is available in the minimum supported perl version. Bundling is in general unsafe, and not future-proof, as new options might gain arguments which would then get misinterpreted, we should not really be using it. But bundling the value into the option is a common pattern and should be allowed. --- debian/changelog | 4 ++++ scripts/dpkg-checkbuilddeps.pl | 2 +- scripts/dpkg-mergechangelogs.pl | 2 +- scripts/dpkg-scanpackages.pl | 2 +- scripts/dpkg-scansources.pl | 2 +- 5 files changed, 8 insertions(+), 4 deletions(-) diff --git a/debian/changelog b/debian/changelog index 22d2b1fc7..0d76488ce 100644 --- a/debian/changelog +++ b/debian/changelog @@ -3,6 +3,10 @@ dpkg (1.20.0) UNRELEASED; urgency=medium [ Guillem Jover ] * libdpkg: Do not generate a backup file for the available database. Closes: #343578 + * perl: Switch Getopt::Long from bundling to bundling_values. This means + the few scripts using Getopt::Long will stop accepting options in the + form «-ab» for «-a -b», which is not future-proof, as it does not allow + these options to get new arguments without making them abiguous. * Build system: - Bump minimal Perl version to 5.24.1. diff --git a/scripts/dpkg-checkbuilddeps.pl b/scripts/dpkg-checkbuilddeps.pl index c5a65e1ab..0621f5f8d 100755 --- a/scripts/dpkg-checkbuilddeps.pl +++ b/scripts/dpkg-checkbuilddeps.pl @@ -22,7 +22,7 @@ use strict; use warnings; -use Getopt::Long qw(:config posix_default bundling no_ignorecase); +use Getopt::Long qw(:config posix_default bundling_values no_ignorecase); use Dpkg (); use Dpkg::Gettext; diff --git a/scripts/dpkg-mergechangelogs.pl b/scripts/dpkg-mergechangelogs.pl index 20b33dc75..0f4d85165 100755 --- a/scripts/dpkg-mergechangelogs.pl +++ b/scripts/dpkg-mergechangelogs.pl @@ -20,7 +20,7 @@ use warnings; use strict; use Scalar::Util qw(blessed); -use Getopt::Long qw(:config posix_default bundling no_ignorecase); +use Getopt::Long qw(:config posix_default bundling_values no_ignorecase); use Dpkg (); use Dpkg::Changelog::Debian; diff --git a/scripts/dpkg-scanpackages.pl b/scripts/dpkg-scanpackages.pl index 6d6d7946e..3d727753d 100755 --- a/scripts/dpkg-scanpackages.pl +++ b/scripts/dpkg-scanpackages.pl @@ -20,7 +20,7 @@ use warnings; use strict; -use Getopt::Long qw(:config posix_default bundling no_ignorecase); +use Getopt::Long qw(:config posix_default bundling_values no_ignorecase); use List::Util qw(none); use File::Find; diff --git a/scripts/dpkg-scansources.pl b/scripts/dpkg-scansources.pl index 3c793b4e3..d92e980db 100755 --- a/scripts/dpkg-scansources.pl +++ b/scripts/dpkg-scansources.pl @@ -20,7 +20,7 @@ use strict; use warnings; -use Getopt::Long qw(:config posix_default bundling no_ignorecase); +use Getopt::Long qw(:config posix_default bundling_values no_ignorecase); use List::Util qw(any); use File::Find; -- Dpkg.Org's dpkg
