This is an automated email from the git hooks/post-receive script.

guillem pushed a commit to branch master
in repository dpkg.

View the commit online:
https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=66a8200338ccd5b2ecea7999d44fce2bf4253611

The following commit(s) were added to refs/heads/master by this push:
     new 66a820033 Dpkg::Source::Package: Turn missing tarball signature error 
into a warning
66a820033 is described below

commit 66a8200338ccd5b2ecea7999d44fce2bf4253611 (HEAD -> master)
Author: Guillem Jover <[email protected]>
AuthorDate: Sun Jun 28 00:37:13 2020 +0200

    Dpkg::Source::Package: Turn missing tarball signature error into a warning
    
    Do this for now, as it is causing unintended fallout, and does not play
    nice (yet) with tarballs repackaged by uscan(1).
    
    While a warning is not really satisfactory, it's good enough while a
    better deployment is devised.
    
    Closes: #963821
---
 debian/changelog                  | 5 +++++
 scripts/Dpkg/Source/Package/V1.pm | 2 +-
 scripts/Dpkg/Source/Package/V2.pm | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/debian/changelog b/debian/changelog
index 13a45681f..f47feafde 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -5,6 +5,11 @@ dpkg (1.20.2) UNRELEASED; urgency=medium
     if it is missing, to help with installation bootstrapping.
     Reported by Johannes Schauer <[email protected]>.
   * update-alternatives: Create the log directory if it is missing.
+  * Perl modules:
+    - Dpkg::Source::Package: Turn the missing expected tarball signature
+      error into a warning for now, as it is causing unintended fallout,
+      and does not play nice (yet) with tarballs repackaged by uscan(1).
+      Closes: #963821
   * Code internals:
     - update-alternatives: Move log_msg() after make_path() so that we can use
       the latter.
diff --git a/scripts/Dpkg/Source/Package/V1.pm 
b/scripts/Dpkg/Source/Package/V1.pm
index 185101714..33cffc20b 100644
--- a/scripts/Dpkg/Source/Package/V1.pm
+++ b/scripts/Dpkg/Source/Package/V1.pm
@@ -433,7 +433,7 @@ sub do_build {
     } else {
         my $key = $self->get_upstream_signing_key($dir);
         if (-e $key) {
-            error(g_('upstream signing key but no upstream tarball 
signature'));
+            warning(g_('upstream signing key but no upstream tarball 
signature'));
         }
     }
 
diff --git a/scripts/Dpkg/Source/Package/V2.pm 
b/scripts/Dpkg/Source/Package/V2.pm
index 2ea1e4eba..05dd3ba64 100644
--- a/scripts/Dpkg/Source/Package/V2.pm
+++ b/scripts/Dpkg/Source/Package/V2.pm
@@ -443,7 +443,7 @@ sub _generate_patch {
         } else {
             my $key = $self->get_upstream_signing_key($dir);
             if (-e $key) {
-                error(g_('upstream signing key but no upstream tarball 
signature'));
+                warning(g_('upstream signing key but no upstream tarball 
signature'));
             }
         }
     }

-- 
Dpkg.Org's dpkg

Reply via email to