This is an automated email from the git hooks/post-receive script. guillem pushed a commit to branch main in repository dpkg.
View the commit online: https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=74aa880ad45ec032ec4501f107c2c6e53789f3b2 The following commit(s) were added to refs/heads/main by this push: new 74aa880ad test: Improve TAP descriptions to clarify we are testing patch(1) 74aa880ad is described below commit 74aa880ad45ec032ec4501f107c2c6e53789f3b2 (HEAD -> main) Author: Guillem Jover <[email protected]> AuthorDate: Mon Jan 2 00:10:36 2023 +0100 test: Improve TAP descriptions to clarify we are testing patch(1) The unit tests did not make it clear that we are testing how the system patch(1) works, and not local code. This has caused bugs reported in the past on systems with unsafe patch(1) implementations. --- scripts/t/Dpkg_Source_Patch.t | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/scripts/t/Dpkg_Source_Patch.t b/scripts/t/Dpkg_Source_Patch.t index f50f15be2..aa5d4376c 100644 --- a/scripts/t/Dpkg_Source_Patch.t +++ b/scripts/t/Dpkg_Source_Patch.t @@ -44,31 +44,31 @@ sub test_patch_escape { # This is CVE-2014-0471 with GNU patch >= 2.7 test_patch_escape('c-style-parsed', "\tmp", 'c-style.patch', - 'Patch cannot escape using known c-style encoded filename'); + 'patch(1) prevents escape using known c-style encoded filename'); # This is CVE-2014-0471 with GNU patch < 2.7 test_patch_escape('c-style-unknown', '\\tmp', 'c-style.patch', - 'Patch cannot escape using unknown c-style encoded filename'); + 'patch(1) prevents escape using unknown c-style encoded filename'); # This is CVE-2014-3865 test_patch_escape('index-alone', 'symlink', 'index-alone.patch', - 'Patch cannot escape using Index: w/o ---/+++ header'); + 'patch(1) prevents escape using Index: w/o ---/+++ header'); test_patch_escape('index-+++', 'symlink', 'index-+++.patch', - 'Patch cannot escape using Index: w/ only +++ header'); + 'patch(1) prevents escape using Index: w/ only +++ header'); test_patch_escape('index-inert', 'symlink', 'index-inert.patch', - 'Patch should not fail to apply using an inert Index:'); + 'patch(1) should not fail to apply using an inert Index:'); ok(-e "$tmpdir/index-inert-tree/inert-file", - 'Patch with inert Index: applies correctly'); + 'patch(1) applies correctly with inert Index:'); # This is CVE-2014-3864 test_patch_escape('partial', 'symlink', 'partial.patch', - 'Patch cannot escape using partial +++ header'); + 'patch(1) prevents escape using partial +++ header'); test_patch_escape('ghost-hunk', 'symlink', 'ghost-hunk.patch', - 'Patch cannot escape using a disabling hunk'); + 'patch(1) prevents escape using a disabling hunk'); # This is CVE-2017-8283 test_patch_escape('indent-header', 'symlink', 'indent-header.patch', - 'Patch cannot escape indented hunks'); + 'patch(1) prevents escape using indented hunks'); 1; -- Dpkg.Org's dpkg
