This is an automated email from the git hooks/post-receive script.

guillem pushed a commit to branch main
in repository dpkg.

View the commit online:
https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=a54ef649da084562600b8fe32fd726bb1523a862

commit a54ef649da084562600b8fe32fd726bb1523a862
Author: Guillem Jover <[email protected]>
AuthorDate: Mon Jan 2 12:30:50 2023 +0100

    Dpkg::Vendor::Debian: Use get_feature() instead of use_feature() for PIE
    
    We are distinguishing the feature being undef to cover the builtin case,
    and use_feature() coerces it to a bool values which makes it lose the
    undef and causes the flags to include PIE flags.
    
    Reported-by: Helmut Grohne <[email protected]>
---
 scripts/Dpkg/Vendor/Debian.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/Dpkg/Vendor/Debian.pm b/scripts/Dpkg/Vendor/Debian.pm
index e36f21664..39ffbf065 100644
--- a/scripts/Dpkg/Vendor/Debian.pm
+++ b/scripts/Dpkg/Vendor/Debian.pm
@@ -427,7 +427,7 @@ sub _add_build_flags {
     ## Area: hardening
 
     # PIE
-    my $use_pie = $flags->use_feature('hardening', 'pie');
+    my $use_pie = $flags->get_feature('hardening', 'pie');
     my %hardening_builtins = $flags->get_builtins('hardening');
     if (defined $use_pie && $use_pie && ! $hardening_builtins{pie}) {
        my $flag = "-specs=$Dpkg::DATADIR/pie-compile.specs";

-- 
Dpkg.Org's dpkg

Reply via email to