This is an automated email from the git hooks/post-receive script. guillem pushed a commit to branch main in repository dpkg.
View the commit online: https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=d909a04b15ac39305dfe979077c7a34d69616c8d commit d909a04b15ac39305dfe979077c7a34d69616c8d Author: Guillem Jover <[email protected]> AuthorDate: Tue Feb 28 23:24:10 2023 +0100 test: Update rationale for perlcritic check suppressions Explain better why these checks are currently disabled. --- t/critic/perlcriticrc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/t/critic/perlcriticrc b/t/critic/perlcriticrc index e2e55b04d..6bdebc0d2 100644 --- a/t/critic/perlcriticrc +++ b/t/critic/perlcriticrc @@ -32,7 +32,7 @@ minimum_regex_length_to_complain_about = 60 allow_delegation_to = new clone [ValuesAndExpressions::ProhibitInterpolationOfLiterals] -# TODO: switch these to q{} ? +# TODO: Switch these to q{} ? allow_if_string_contains_single_quote = 1 ## @@ -57,10 +57,10 @@ allow_if_string_contains_single_quote = 1 # Forcing this just turns into noise (depending on the context, it makes sense). [-CodeLayout::RequireTrailingCommas] -# These are fine. +# These are fine, and given/when are marked as experimental. [-ControlStructures::ProhibitCascadingIfElse] -# These are fine, too many in the code base anyway. +# These are fine, and too many in the code base anyway. [-ControlStructures::ProhibitPostfixControls] # These are fine, usually as long as they are not double negations. @@ -97,7 +97,7 @@ allow_if_string_contains_single_quote = 1 # TODO: While valid, these are part of the public/current API. [-Subroutines::ProhibitBuiltinHomonyms] -# Needed. +# TODO: Needed but we should switch away, and with perl 5.36 use signatures. [-Subroutines::ProhibitSubroutinePrototypes] # Adding these seems like more noise. @@ -125,7 +125,7 @@ allow_if_string_contains_single_quote = 1 # Used for help output. [-ValuesAndExpressions::ProhibitImplicitNewlines] -# Octals are fine. +# TODO: Octals are fine, but revisit with perl 5.34 octal syntax 0o<nnnn>. [-ValuesAndExpressions::ProhibitLeadingZeros] # TODO: Check it out, some magic numbers are fine, octals for example. -- Dpkg.Org's dpkg
