This is an automated email from the git hooks/post-receive script.

guillem pushed a commit to branch main
in repository dpkg.

View the commit online:
https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=a004016c00639cca59b914c61349b3ec11f64b1c

commit a004016c00639cca59b914c61349b3ec11f64b1c
Author: Guillem Jover <[email protected]>
AuthorDate: Sat May 6 22:36:56 2023 +0200

    Dpkg::Shlibs::Objdump: Add back the ARM ABI mismatch mask but commented out
    
    Add a comment with the current state, and rationale why ARM does not
    have the ABI mismatch mask set, so that it does not get accidentally
    added back until the situation has been checked to be safe, or dealt
    with.
    
    Ref: #853793
---
 scripts/Dpkg/Shlibs/Objdump.pm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/scripts/Dpkg/Shlibs/Objdump.pm b/scripts/Dpkg/Shlibs/Objdump.pm
index 661d07424..bc2909c84 100644
--- a/scripts/Dpkg/Shlibs/Objdump.pm
+++ b/scripts/Dpkg/Shlibs/Objdump.pm
@@ -205,6 +205,17 @@ my %elf_mach_map = (
 # always better to not mask a flag, because that preserves the historical
 # behavior, and we do not drop dependencies.
 my %elf_flags_mask = (
+    # XXX: The mask for ARM had to be disabled due to objects in the wild
+    # with EABIv4, while EABIv5 is the current one, and the soft and hard
+    # flags not always being set on armel and armhf respectively, although
+    # the Tag_ABI_VFP_args in the ARM attribute section should always be
+    # present on armhf, and there are even cases where both soft and hard
+    # float flags are set at the same time(!). Once these are confirmed to
+    # be fixed, we could reconsider enabling the below for a more strict
+    # ABI mismatch check. See #853793.
+#   EM_ARM()                => EF_ARM_EABI_MASK |
+#                              EF_ARM_NEW_ABI | EF_ARM_OLD_ABI |
+#                              EF_ARM_SOFT_FLOAT | EF_ARM_HARD_FLOAT,
     EM_IA64()               => EF_IA64_ABI64,
     EM_LOONGARCH()          => EF_LOONGARCH_ABI_MASK,
     EM_MIPS()               => EF_MIPS_ABI_MASK | EF_MIPS_ABI2,

-- 
Dpkg.Org's dpkg

Reply via email to