This is an automated email from the git hooks/post-receive script. guillem pushed a commit to branch main in repository dpkg.
View the commit online: https://git.dpkg.org/cgit/dpkg/dpkg.git/commit/?id=474977f119a104cdd2c9160db4f22a7253629758 commit 474977f119a104cdd2c9160db4f22a7253629758 Author: Guillem Jover <[email protected]> AuthorDate: Sat Sep 13 04:51:10 2025 +0200 dselect: Remove useless topic variable use in split calls in method scripts The topic variable is already implied when not passed. Changelog: internal Warned-by: perlcritic Fixes: BuiltinFunctions::ProhibitUselessTopic --- dselect/methods/file/install.sh | 2 +- dselect/methods/media/install.sh | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/dselect/methods/file/install.sh b/dselect/methods/file/install.sh index d96b56e36..890612f91 100755 --- a/dselect/methods/file/install.sh +++ b/dselect/methods/file/install.sh @@ -53,7 +53,7 @@ while true; do s/\s*\n$//; $package = $_ if s/^Package: //i; $version = $_ if s{^Version: }{}i; - @filename = split(/ /,$_) if s/^Filename: //i; + @filename = split / / if s/^Filename: //i; } close $predep_fh; die "internal error - no package" if length($package) == 0; diff --git a/dselect/methods/media/install.sh b/dselect/methods/media/install.sh index 68fdcc471..6c2a693a1 100755 --- a/dselect/methods/media/install.sh +++ b/dselect/methods/media/install.sh @@ -95,7 +95,7 @@ while true; do $package = $_ if s/^Package: //i; $version = $_ if s{^Version: }{}i; /^X-Medium:\s+(.*)\s*/ and $medium = $1; - @filename = split(/ /,$_) if s/^Filename: //i; + @filename = split / / if s/^Filename: //i; } close $predep_fh; die "internal error - no package" if length($package) == 0; @@ -194,7 +194,7 @@ perl -MDpkg::Version -MDselect::Method::Media -e ' s/\n\s+/ /g; my %status = ( "", - split /^(\S*?):\s*/m, $_, + split /^(\S*?):\s*/m, ); map { chomp $status{$_}; $status{$_} =~ s/^\s*(.*?)\s*$/$1/;} keys %status; my @pstat = split(/ /, $status{Status}); @@ -220,7 +220,7 @@ perl -MDpkg::Version -MDselect::Method::Media -e ' s/\n\s+/ /g; my %avail = ( "", - split /^(\S*?):\s*/m, $_, + split /^(\S*?):\s*/m, ); map { chomp $avail{$_}; $avail{$_} =~ s/^\s*(.*?)\s*$/$1/;} keys %avail; -- Dpkg.Org's dpkg
