Your message dated Sat, 25 Oct 2003 17:02:14 -0400
with message-id <[EMAIL PROTECTED]>
and subject line Bug#162691: fixed in dpkg 1.10.16
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 12 May 2003 01:11:16 +0000
>From [EMAIL PROTECTED] Sun May 11 20:11:14 2003
Return-path: <[EMAIL PROTECTED]>
Received: from kom-pc-aw.ethz.ch [129.132.66.20]
by master.debian.org with smtp (Exim 3.12 1 (Debian))
id 19F1qU-0000so-00; Sun, 11 May 2003 20:11:14 -0500
Received: (qmail 12483 invoked by uid 9289); 12 May 2003 01:10:43 -0000
Date: Mon, 12 May 2003 03:10:43 +0200
From: Arno Wagner <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
Subject: Fixed: md5sum for files > 2GB
Message-ID: <[EMAIL PROTECTED]>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.4i
Delivered-To: [EMAIL PROTECTED]
X-Spam-Status: No, hits=-12.3 required=4.0
tests=BAYES_01,HAS_PACKAGE,USER_AGENT_MUTT
autolearn=ham version=2.53-bugs.debian.org_2003_05_09
X-Spam-Level:
X-Spam-Checker-Version: SpamAssassin 2.53-bugs.debian.org_2003_05_09
(1.174.2.15-2003-03-30-exp)
Package: dpkg
Version: 1.10.9
Kernel: Linux debian 2.4.21-rc1-ac2 #3 Tue Apr 29 20:06:05 CEST 2003 i686
unknown unknown GNU/Linux
libc: 2.3.1-16
Affected: dpkg-1.10.9 and earlier
Dear dpkg maintainer!
As several people before reported before, 'md5sum' fails with a
non-intuitive message "success" when called on files larger than
2GB. Example:
wagner /aux/v>ls -al aux.tar
-rw-r--r-- 1 wagner users 3928698880 May 12 01:26 aux.tar
wagner /aux/v>md5sum aux.tar
aux.tar: Success
however:
wagner /aux/v>cat aux.tar | md5sum
ecd7d51416837f891a344ccb61e39dc3 -
A look into the code of md5sum.c revealed that for reads from stdin
the function 'fd_md5' is called without result checking, while for
file arguments it is called with result checking. The result type of
'fd_md5' is 'ssize_t', which on some platforms (e.g. i386) is a 32 bit
signed int. It seems that the result of 'fd_md5' is the number of
bytes processed. When this number overflows, 'fd_md5' may return a
negative result. The error handling code then incorrectly detects an
error and calls 'perror' which outputs 'Success', since no error
actually happened.
Fix:
Explicitely check 'errno' when 'fd_md5' returns a negative result.
This should allways work, regardless of platform or size of 'ssize_t'.
Diff:
diff dpkg-1.10.9/utils/md5sum.c dpkg-1.10.9-patched/utils/md5sum.c
23a24
> #include <errno.h>
198a200,205
> /* Since on some systems 'ssize_t' is only 32 bit,
> * 'fd_md5' may return < 0 on files > 2GB.
> * Do additional checking to be sure errors are
> * actually errors and not numeric overflows.
> */
> errno = 0;
200c207
< if ( ret >= 0 )
---
> if ( ret >= 0 || errno == 0 )
Regards,
Arno Wagner
--
Arno Wagner, Communication Systems Group, ETH Zuerich, [EMAIL PROTECTED]
GnuPG: ID: 1E25338F FP: 0C30 5782 9D93 F785 E79C 0296 797F 6B50 1E25 338F
----
For every complex problem there is an answer that is clear, simple,
and wrong. -- H L Mencken
---------------------------------------
Received: (at 162691-close) by bugs.debian.org; 25 Oct 2003 21:08:27 +0000
>From [EMAIL PROTECTED] Sat Oct 25 16:08:22 2003
Return-path: <[EMAIL PROTECTED]>
Received: from auric.debian.org [206.246.226.45]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1ADVdy-0001cq-00; Sat, 25 Oct 2003 16:08:18 -0500
Received: from katie by auric.debian.org with local (Exim 3.35 1 (Debian))
id 1ADVY6-0003Rv-00; Sat, 25 Oct 2003 17:02:14 -0400
From: Adam Heath <[EMAIL PROTECTED]>
To: [EMAIL PROTECTED]
X-Katie: $Revision: 1.42 $
Subject: Bug#162691: fixed in dpkg 1.10.16
Message-Id: <[EMAIL PROTECTED]>
Sender: Archive Administrator <[EMAIL PROTECTED]>
Date: Sat, 25 Oct 2003 17:02:14 -0400
Delivered-To: [EMAIL PROTECTED]
Source: dpkg
Source-Version: 1.10.16
We believe that the bug you reported is fixed in the latest version of
dpkg, which is due to be installed in the Debian FTP archive:
dpkg-dev_1.10.16_all.deb
to pool/main/d/dpkg/dpkg-dev_1.10.16_all.deb
dpkg-doc_1.10.16_all.deb
to pool/main/d/dpkg/dpkg-doc_1.10.16_all.deb
dpkg_1.10.16.dsc
to pool/main/d/dpkg/dpkg_1.10.16.dsc
dpkg_1.10.16.tar.gz
to pool/main/d/dpkg/dpkg_1.10.16.tar.gz
dpkg_1.10.16_i386.deb
to pool/main/d/dpkg/dpkg_1.10.16_i386.deb
dselect_1.10.16_i386.deb
to pool/main/d/dpkg/dselect_1.10.16_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [EMAIL PROTECTED],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Adam Heath <[EMAIL PROTECTED]> (supplier of updated dpkg package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [EMAIL PROTECTED])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 25 Oct 2003 15:46:16 -0500
Source: dpkg
Binary: dpkg-doc dpkg dselect dpkg-dev dpkg-static
Architecture: source all i386
Version: 1.10.16
Distribution: unstable
Urgency: low
Maintainer: Dpkg Development <[email protected]>
Changed-By: Adam Heath <[EMAIL PROTECTED]>
Description:
dpkg - Package maintenance system for Debian
dpkg-dev - Package building tools for Debian
dpkg-doc - Dpkg Internals Documentation
dselect - a user tool to manage Debian packages
Closes: 111711 112057 117518 138244 142370 149142 151800 151802 155219 157819
162154 162691 164906 167379 171489 192972 209355 211816 212796
Changes:
dpkg (1.10.16) unstable; urgency=low
.
* Almost *EVERY* damn file was including config.h in the wrong spot.
After making it the first include, then off_t/size_t/etc could actually
be redefined to be 64-bit compatible.
* Jordi Mallach <[EMAIL PROTECTED]>:
Fix configure to set HAVE_SETLOCALE. Closes: #211816
* "Lo�c Le Loarer" <[EMAIL PROTECTED]>:
Add a -d|--chdir option to start-stop-daemon. Closes: #151802
* Split the background block into 2 parts: one that does the fork, and
opens /dev/tty and /dev/null, and one that does everything else. The
second block is then moved to be run right before the exec. This
allows error messages to be seen from the child(previously, they were
lost), and allows for the chroot to not require the device files.
These changes based on the bugs filed by:
Marc Herbert <[EMAIL PROTECTED]>: Closes: #155219
Lo�c Le Loarer <[EMAIL PROTECTED]>: Closes: #151800
* Mario Lang <[EMAIL PROTECTED]>:
When --start, --startas and --pidfile are given, print 'process'
instead of '(null)' for the process name, if it's already running.
Closes: #209355
* Imported several translated manpages, from debian-doc cvs:
* Spanish: 822-date.1 cleanup-info.8 deb-control.5 deb-old.5
deb.5 dpkg-checkbuilddeps.1 dpkg-deb.1 dpkg-divert.8 dpkg-name.1
dpkg-scanpackages.8 dpkg-split.8 dpkg-statoverride.8 dpkg.8
dselect.8 md5sum.1 start-stop-daemon.8 update-alternatives.8
"Esteban Manchado Vel�zquez" <[EMAIL PROTECTED]>: Closes: #171489
* French: deb.5
Julien Louis <[EMAIL PROTECTED]>: Closes: #164906
* Portuguese: dpkg.8 dselect.8
* Matt Zimmerman <[EMAIL PROTECTED]>
In dpkg's manpage, -O had an inverted word. Closes: #111711
* Marcin Owsiany <[EMAIL PROTECTED]>:
Fix Polish translation of 'conflicts with' Closes: #112057
* Jiri Masik <[EMAIL PROTECTED]>:
Improve Czech translation of: "dpkg - warning: ignoring request to
remove %s which isn't installed." Closes: #117518
* Marco Nenciarini <[EMAIL PROTECTED]>:
Fix missing space in Italian translation when listing files, and the
file is diverted. Closes: #138244
* Piotr Roszatycki <[EMAIL PROTECTED]>:
Update Polish translation. Closes: #142370
* Martin Quinson <[EMAIL PROTECTED]>:
Fix missing space in French translation of: "%s - warning: downgrading
%.250s from %.250s to %.250s.\n" Closes: #149142
* Hidetaka Iwai <[EMAIL PROTECTED]>:
Fix typo in Japanese translation of dpkg --force-help; dowgrade ->
downgrade: Closes: #157819
* Martin Quinson <[EMAIL PROTECTED]>:
Fix French translation when listing files, and the file is diverted.
Closes: #162154
* Rune Schjellerup <[EMAIL PROTECTED]>:
Fix Danish translation of(was missing the leading space): " does not
appear to be available\n" Closes: #192972
* Fix md5sum when handling large files. Closes: #162691
* Fix dpkg-checkbuilddeps calling of parsedep. It wasn't setting
use_arch. Closes: #212796.
* Joey Hess <[EMAIL PROTECTED]>:
Change formatting of info.dir. Closes: #167379.
Files:
f25c4f9b73002753e8efdc33a57d7ad5 756 base required dpkg_1.10.16.dsc
240bb2a8ad67ff8fe536d49b1bc17127 1601179 base required dpkg_1.10.16.tar.gz
1fad4d36d2ab50e32800eaaeba1f3bac 1136408 base required dpkg_1.10.16_i386.deb
e6982ddda530904a1f9008bdb9bce0f2 95046 base required dselect_1.10.16_i386.deb
12b7a1bef1573359f170210efef6224c 114224 utils standard dpkg-dev_1.10.16_all.deb
b35417beff28f92dd7e7971e5139195a 10640 doc optional dpkg-doc_1.10.16_all.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE/muKFiix9wovUpIkRAjPxAJ9tYar55J3vW1BhiP/IbGCGgsfUAACdFijn
wMmrspkeCYHSEchxsHRRa+8=
=t1o8
-----END PGP SIGNATURE-----
