Package: dpkg-dev
Version: 1.10.16
Severity: minor
Tags: patch

In /usr/bin/dpkg-checkbuilddeps, two bugs:

(1) (minor): in sub usage, the usage instruction reads:

Usage: dpkg-checkbuild [-B] [control-file]

    but of course the program is now called dpkg-checkbuilddeps

(2) (more significant)
    When checking the Build-Depends and Build-Conflicts fields (line
    43 onwards), it puts _all_ of the results in @unmet, rather than
    putting the unsatisfied depends in @unmet and the unsatisfied
    conflicts in @conflicts.

Patch which fixes both of these:

--- /usr/bin/dpkg-checkbuilddeps        2003-10-25 21:51:27.000000000 +0100
+++ /tmp/dpkg-checkbuilddeps    2003-10-28 10:26:45.000000000 +0000
@@ -11,7 +11,7 @@
 
 sub usage {
        print STDERR <<EOF;
-Usage: dpkg-checkbuild [-B] [control-file]
+Usage: dpkg-checkbuilddeps [-B] [control-file]
        -B              binary-only, ignore -Indep
        control-file    control file to process [Default: debian/control]
 EOF
@@ -44,13 +44,13 @@
        push @unmet, build_depends(parsedep($fi{"C Build-Depends"}, 1), 
@status);
 }
 if (defined($fi{"C Build-Conflicts"})) {
-       push @unmet, build_conflicts(parsedep($fi{"C Build-Conflicts"}, 1), 
@status);
+       push @conflicts, build_conflicts(parsedep($fi{"C Build-Conflicts"}, 1), 
@status);
 }
 if (! $binary_only && defined($fi{"C Build-Depends-Indep"})) {
        push @unmet, build_depends(parsedep($fi{"C Build-Depends-Indep"}, 1), 
@status);
 }
 if (! $binary_only && defined($fi{"C Build-Conflicts-Indep"})) {
-       push @unmet, build_conflicts(parsedep($fi{"C Build-Conflicts-Indep"}, 
1), @status);
+       push @conflicts, build_conflicts(parsedep($fi{"C 
Build-Conflicts-Indep"}, 1), @status);
 }
 
 if (@unmet) {


   Julian

-- 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

        Julian Gilbey, website: http://www.polya.uklinux.net/
   Debian GNU/Linux Developer, see: http://people.debian.org/~jdg/
     Visit http://www.thehungersite.com/ to help feed the hungry


Reply via email to