Hi! On Wed, 2013-04-24 at 08:24:11 +0200, Niels Thykier wrote: > While reviewing this commit, I noticed a number of cases where write > handles were closed but the return value was not checked. They appear > to be unrelated to the changes in the commit (i.e. the problem was there > prior to the commit).
Yeah, there are many (see the script I posted some days ago): 86 Perl::Critic::Policy::InputOutput::RequireCheckedClose (2) 11 Perl::Critic::Policy::InputOutput::RequireCheckedOpen (3) 324 Perl::Critic::Policy::InputOutput::RequireCheckedSyscalls (1) I think I started fixing those on my perlcritic branch, need to re-review some pretty large and menial patches first, but should get there hopefully soon. In any case, thanks for reviewing. :) [0] <http://lists.debian.org/debian-dpkg/2013/04/msg00018.html> Thanks, Guillem -- To UNSUBSCRIBE, email to [email protected] with a subject of "unsubscribe". Trouble? Contact [email protected] Archive: http://lists.debian.org/[email protected]
