Your message dated Tue, 18 Nov 2014 23:48:50 +0000 with message-id <[email protected]> and subject line Bug#770110: fixed in debian-edu-install 1.818 has caused the Debian Bug report #770110, regarding debian-edu-install: Bogus error logged from edu-eatmydata-install to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 770110: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=770110 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: debian-edu-profile-udeb Version: 1.817 Severity: important Tags: patch pending During installation when the quick installation using eatmydata is enabled, an error is logged stating "unable to find /usr/bin/eatmydata after installing the eatmydata package". This is logged from pre-pkgsel even if eatmydata was successfully installed in the post-baseinstaller step. When doing test installs, all errors in the log is presented to the user in a popup dialog, and this bogus error is confusing at best and hurting our reputation at worst. The reason for the problem is this incorrect if test in edu-eatmydata-install: if [ -x /target/usr/bin/eatmydata ] && \ [ ! -f /target/etc/apt/apt.conf.d/95debian-edu-install-dpkg-eatmydata ]; then When this test fail, the error is logged. But the error should only be logged when the first part of the test fail. If the second part hit, only an informational message stating that eatmydata is already active is needed. The following patch solve the problem: diff --git a/tools/edu-eatmydata-install b/tools/edu-eatmydata-install index da82d6d..9ab19c2 100755 --- a/tools/edu-eatmydata-install +++ b/tools/edu-eatmydata-install @@ -19,8 +19,8 @@ trap at_exit INT TERM EXIT enable_override() { apt-install eatmydata || true - if [ -x /target/usr/bin/eatmydata ] && \ - [ ! -f /target/etc/apt/apt.conf.d/95debian-edu-install-dpkg-eatmydata ]; then + if [ -x /target/usr/bin/eatmydata ] ; then + if [ ! -f /target/etc/apt/apt.conf.d/95debian-edu-install-dpkg-eatmydata ]; then info "Adding apt config to call dpkg via eatmydata" printf "#!/bin/sh\nexec eatmydata dpkg \"\$@\"\n" \ > /target/var/tmp/dpkg-eatmydata @@ -28,6 +28,9 @@ enable_override() { cat > /target/etc/apt/apt.conf.d/95debian-edu-install-dpkg-eatmydata <<EOF Dir::Bin::dpkg "/var/tmp/dpkg-eatmydata"; EOF + else + info "apt redirect for eatmydata already in place" + fi else error "unable to find /usr/bin/eatmydata after installing the eatmydata package" fi I'll commit the patch to git. -- Happy hacking Petter Reinholdtsen
--- End Message ---
--- Begin Message ---Source: debian-edu-install Source-Version: 1.818 We believe that the bug you reported is fixed in the latest version of debian-edu-install, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Petter Reinholdtsen <[email protected]> (supplier of updated debian-edu-install package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Format: 1.8 Date: Wed, 19 Nov 2014 00:41:44 +0100 Source: debian-edu-install Binary: debian-edu-install debian-edu-profile-udeb debian-edu-install-udeb Architecture: source all Version: 1.818 Distribution: unstable Urgency: low Maintainer: Debian Edu Developers <[email protected]> Changed-By: Petter Reinholdtsen <[email protected]> Description: debian-edu-install - Set d-i values to install Debian Edu without questions debian-edu-install-udeb - Execute Debian Edu debian-installer profile (udeb) debian-edu-profile-udeb - Choose Debian Edu profile (udeb) Closes: 770110 Changes: debian-edu-install (1.818) unstable; urgency=low . * Re-enable eatmydata during installation now that bug #765694 is fixed in unstable and accepted for testing. * Adjust edu-eatmydata-install to not report an error when eatmydata already is activated, but instead log that it is already in place. This avoid a bogus error being reported to those testing Debian Edu Jessie (Closes: #770110). Checksums-Sha1: f15684c7e6dd19a8623a9af7ab095b2458ae4e42 1465 debian-edu-install_1.818.dsc b39b74dd8ffbe96b5898a5c244816a4cf24fedff 172052 debian-edu-install_1.818.tar.gz 04afab663cb92c41330945ffa711cca2dd28a01e 59954 debian-edu-install_1.818_all.deb 6334c73c219788bc7c5e6bd2067157ad5eb24505 64628 debian-edu-profile-udeb_1.818_all.udeb cd7dda741db74868d65d9340f6eedce6055b2399 2698 debian-edu-install-udeb_1.818_all.udeb Checksums-Sha256: 631d60d65f85d221784ffcc18bd71417924ec9a7f6e145842f8b08b851db8bb3 1465 debian-edu-install_1.818.dsc 0805563bbcbdc73a832cac36fee48b1773398a58dd8228dde8171e840f386c2d 172052 debian-edu-install_1.818.tar.gz 3372201f0a14465a81a422889c175aeb20b5b2c301d9e8c8a766eeda917fc792 59954 debian-edu-install_1.818_all.deb 3f1144892dc4c0822e50069a019910c28830f6326ebafd6c2ce044a78ac6e890 64628 debian-edu-profile-udeb_1.818_all.udeb f6c62c480629ae1a18922b2cf2865aa924aba33ebef0be330b62492f8d3f9e2b 2698 debian-edu-install-udeb_1.818_all.udeb Files: c8b055a6acab7f219f0218e12f76dc4d 1465 misc optional debian-edu-install_1.818.dsc 2074410eb8bb3840c112795de90e4933 172052 misc optional debian-edu-install_1.818.tar.gz eda9a623267540c499e84473711478b3 59954 misc extra debian-edu-install_1.818_all.deb e8ee6f45085ce916d517729451cb964d 64628 debian-installer optional debian-edu-profile-udeb_1.818_all.udeb afc883376d28ff3c15542260843c7015 2698 debian-installer optional debian-edu-install-udeb_1.818_all.udeb -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) iD8DBQFUa9mT20zMSyow1ykRAt/CAJ9gX8VP9IaPqDDuIaOKL1FRL8feOACgpoNn 4tu9jLU0LmH3hCPz2RoV4Lk= =+E+M -----END PGP SIGNATURE-----
--- End Message ---
