Hi Paul,

On Thu, Mar 15, 2018 at 03:44:02PM +0100, Paul Gevers wrote:
> I believe the attached patch would be able to fix this bug and on top of
> that make the test script a lot simpler and easier to understand. Please
> verify that the script still does what is intended.

awesome, thanks a lot! (did you test it manually?)

> Please note the chmod on d/t/test-metapkgs that is required.

noted & thankfully you provided a git patch, so thats easy. :)

> Also, I wonder if really all the current combinations of DESKTOP and
> PROFILE need to be tested, or some smarter combination could be chosen
> such that test time can be reduced while still having confidence that
> most code paths are tested.

I think the latter would be sufficient indeed.

> I haven't optimized for this yet.

I'd certainly welcome another patch based on this one ;)


-- 
cheers,
        Holger

Attachment: signature.asc
Description: PGP signature

Reply via email to