2014-08-05 18:16 GMT+02:00 Sebastiaan Couwenberg <[email protected]>:
> > For starters I recommend the usage of Config::Model, specifically it's > dpkg support for a consistently formatted d/control. > > Its usage is documented in the Debian GIS Policy: > > http://pkg-grass.alioth.debian.org/policy/policy.html#cme > > This would fix the reported lintian errors: > > E: qmapshack source: multiline-field maintainer > E: qmapshack: multiline-field maintainer > Fixed. > Secondly I'm not sure about some of the build dependencies. > > You're currently using: > > debhelper (>= 9.20120417~), > You need this version of debhelper to get proper hardening with cmake https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=668813 > libgdal1-dev (>= 1.5.2-3) | libgdal-dev, > libproj-dev | proj, > > If you don't intent to support backports, the following should be > sufficient: > > debhelper (>= 9), > libgdal-dev (>= 1.10.1-0~), > libproj-dev, > > Ok > >From the get-orig-source target in debian/rules I see that the ~repack0 > upstream version suffix is used to denote the repacking done to remove > the .hg data for the Mercurial repository. > > The suffix '+dfsg' is more common, but more appropriate if the repacking > is done to strip DFSG non-free files. That doesn't seem to be the case > so '+ds' is probably the better choice in this case. > > Ok > With the recent enhancements in uscan it can strip files listed in the > Files-Excluded section of the debian/copyright file, you could use this > instead of the tar dance in debian/rules. > > The current get-orig-source target can also be simplified by using `tar > --delete`. For an example see its usage in postgis: > > > http://anonscm.debian.org/cgit/pkg-grass/postgis.git/tree/debian/get-orig-source > > This way of getting orig source repacked is becoming standard in pkg-multimedia team where I co-maintain some packages. Some I am used to it moreover uscan currently doesn't work with bitbucket :( https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=749225 So this solution allows me get orig source via wget. > Finally the package contains the qlandkartegt.menu file, which doesn't > seem appropriately named for qmapshack. And appears unused in the package. > Yes starting point were debian/* files from qlandkartegt ;) as probably guessed. Fixed. qmapshack now installing png icon instead of xpm. What is your prefered way for fixing? regards mira
