On 5/3/20 5:57 PM, Sebastiaan Couwenberg wrote: > On 5/3/20 11:39 AM, Joachim Langenbach wrote: >>> debian/changelog:
This is good now. In the future update the changelog with dch when packaging a new upstream release: https://debian-gis-team.pages.debian.net/policy/packaging.html#git-new-upstream >>> debian/control: >>> >>> Restructure the file with `cme` as documented in the policy: >>> >>> https://debian-gis-team.pages.debian.net/policy/policy.html#cme >>> >>> Using both debhelper (>=10) & debhelper-compat (=12) defeats the >>> purpose of debhelper-compat, use only that. See for example: >>> >>> https://salsa.debian.org/debian-gis-team/pydecorate/-/blob/debian/0.3.1-1/de >>> bian/control >>> >>> Note that using compat 12 complicates backports to Ubuntu LTS releases >>> which the UbuntuGIS project does, as documented in the policy: >>> >>> https://debian-gis-team.pages.debian.net/policy/policy.html#debian-compat >> >> Reverted to 10 > > debhelper-compat support was added in debhelper 11, when using compat > level 10 the build dependency is: > > debhelper (>= 10~) > > And debian/compat exists and contains 10. > > See: > > > https://salsa.debian.org/debian-gis-team/package_template/-/blob/master/debian/control#L6 > > https://salsa.debian.org/debian-gis-team/package_template/-/blob/master/debian/compat > >>> The markdown syntax in the extended description is not used by most >>> consumers of this data, it should just be plain text. >>> >>> Relevant policy section: >>> >>> >>> https://www.debian.org/doc/debian-policy/ch-binary.html#the-description-of-a >>> -package >>> >>> The Documentation paragraph and the See .. for more paragraph are not >>> appropriate for an extended description. >>> >> >> Fixed > > The extended description for the mercantile package is the same as for > python3-mercantile. Add a paragraph explaining what the package > contains, see: > > > https://salsa.debian.org/debian-gis-team/python-stetl/-/blob/master/debian/control This still needs to be fixed. >>> debian/copyright: Because the license and copyright holder are the same, the * and docs/* sections should be merged. >>> debian/patches/0001-removed-coveralls-from-test-requirements.patch This is mostly good now, an empty line between the headers and body improves readability. You also need to configure your quiltc and refresh the patch: https://debian-gis-team.pages.debian.net/policy/policy.html#quilt >>> debian/rules: Instead of changing directory use `make -C docs clean` like the build target. Instead of using `rm -f` use $(RM) which expands to `rm -f`. An empty line between dh_auto_<foo> and the custom commands improves readability. Removing the two dot directories is probably not required. Have you tried building the package twice in a row? gbp buildpackage --git-pbuilder --git-pbuilder-options="--twice" >>> debian/watch: To make it more robust the patten for the tag needs to include alternatives when the 'v' prefix is not used. See: https://salsa.debian.org/debian-gis-team/fiona/-/blob/master/debian/watch Kind Regards, Bas -- GPG Key ID: 4096R/6750F10AE88D4AF1 Fingerprint: 8182 DE41 7056 408D 6146 50D1 6750 F10A E88D 4AF1
