Hi Florian, thank you for your review. I'll have time to send next version in second half of July.
> * Petr Vorel: > > diff --git a/NEWS b/NEWS > > index a660fc59a8..cfaf50c816 100644 > > --- a/NEWS > > +++ b/NEWS > > @@ -33,6 +33,14 @@ Major new features: > > Deprecated and removed features, and other changes affecting compatibility: > > +* Remove configure option --enable-obsolete-nsl. libnsl is only built as > > shared > > + library for backward compatibility and the NSS modules libnss_compat, > > + libnss_nis and libnss_nisplus are not built at all, libnsl's headers > > aren't > > + installed. This compatibility is kept only for architectures and ABIs > > that > > + have been added in or before version 2.28. Replacement implementations > > based > > + on TI-RPC, which additionally support IPv6, are available from > > + <https://github.com/thkukuk/>. > > + > Please add two spaces after sentence-ending periods. And wrap the lines > a bit earlier (column 72 or so). Sure, sorry (my setup is 80, but I'll set it 72 for glibc). > > diff --git a/grp/initgroups.c b/grp/initgroups.c > > index f4c4e986e9..0c17141117 100644 > > --- a/grp/initgroups.c > > +++ b/grp/initgroups.c > > @@ -31,12 +31,6 @@ > > #include "../nscd/nscd-client.h" > > #include "../nscd/nscd_proto.h" > > -#ifdef LINK_OBSOLETE_NSL > > -# define DEFAULT_CONFIG "compat [NOTFOUND=return] files" > > -#else > > -# define DEFAULT_CONFIG "files" > > -#endif > > - > That looks a bit like a pre-existing bug—we do have nss_compat even > without libnsl. But the change itself looks okay. Hm, I'll have look into it after this patchset is finished, but not sure if I'm able to fix this. > > diff --git a/manual/nss.texi b/manual/nss.texi > > index 821469a78a..7cb307246a 100644 > > --- a/manual/nss.texi > > +++ b/manual/nss.texi > > @@ -328,17 +328,11 @@ For the @code{hosts} and @code{networks} databases > > the default value is > > the DNS service not to be available but if it is available the answer it > > returns is definitive. > > -The @code{passwd}, @code{group}, and @code{shadow} databases are > > +The @code{passwd}, @code{group}, and @code{shadow} databases was > > traditionally handled in a special way. The appropriate files in the > > -@file{/etc} directory are read but if an entry with a name starting > > -with a @code{+} character is found NIS is used. This kind of lookup > > -remains possible if @theglibc{} was configured with the > > -@code{--enable-obsolete-nsl} option and the special lookup service > > -@code{compat} is used. If @theglibc{} was configured with the > > -@code{--enable-obsolete-nsl} option the default value for the three > > -databases above is @code{compat [NOTFOUND=return] files}. If the > > -@code{--enable-obsolete-nsl} option was not used the default value > > -for the services is @code{files}. > > +@file{/etc} directory were read but if an entry with a name starting > > +with a @code{+} character was found NIS was used. This kind of lookup > > +was removed and now the default value for the services is @code{files}. > I wonder if it makes sense to reference nss_compat here? Hm, libnss_compat is not built (now libnsl is only built as shared library, for platforms where it was supported), so what exactly would you put here? > Thanks, > Florian Kind regards, Petr
